core: use blockchain's block cache for headers #23299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terapi09
approved these changes
Jul 29, 2021
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 4, 2021
reds
pushed a commit
to reds/go-ethereum
that referenced
this pull request
Aug 28, 2021
i-norden
pushed a commit
to cerc-io/go-ethereum
that referenced
this pull request
Sep 10, 2021
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at #23277 I noticed that
GetTransactionReceiptfetches the same block body twice and its header once from storage. This PR targets one of those, i.e. getting the header of a block when that block is already cached inBlockchain.Alternatively I could warm the headerchain's cache when a block is cached.
This only saves one lookup for each block that's cached (when the header is not)..