Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: fix panic in accesslist creation #23225

Merged
merged 4 commits into from Jul 28, 2021
Merged

internal/ethapi: fix panic in accesslist creation #23225

merged 4 commits into from Jul 28, 2021

Conversation

MariusVanDerWijden
Copy link
Member

closes #23223

holiman
holiman reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it fixes the panic, which is good, but I'm a bit unsure of the semantics here. So we tell it to apply a tx with 0 tipcap and 0 maxTipand0` gas -- won't it panic on invalid basefee?

holiman
holiman approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's fine since we have nobasefee=true set

ghost
ghost reviewed Jul 16, 2021
View reviewed changes
internal/ethapi/api.go Outdated
if gasPrice == nil {
gasPrice = new(big.Int)
}
msg := types.NewMessage(args.from(), args.To, uint64(*args.Nonce), args.Value.ToInt(), uint64(*args.Gas), gasPrice, big.NewInt(0), big.NewInt(0), args.data(), accessList, false)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest assigning it outside of the for loop

	// gas price fallback
	if args.GasPrice == nil {
		args.GasPrice = (*hexutil.Big)(big.NewInt(0))
	}

rjl493456442
rjl493456442 reviewed Jul 19, 2021
View reviewed changes
internal/ethapi/api.go Outdated
if gasPrice == nil {
gasPrice = new(big.Int)
}
msg := types.NewMessage(args.from(), args.To, uint64(*args.Nonce), args.Value.ToInt(), uint64(*args.Gas), gasPrice, big.NewInt(0), big.NewInt(0), args.data(), accessList, false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use the args.toMessage() function instead? Perhaps you can re-assign the accessList after converting it to the message. So that you don't need to handle the gasPrice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep using to message now, and set the accesslist beforehand

@holiman
Copy link
Contributor

holiman commented Jul 27, 2021 

internal/ethapi/api.go:1446:4: ineffectual assignment to gasPrice (ineffassign)

holiman
holiman reviewed Jul 27, 2021
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
@holiman
Copy link
Contributor

holiman commented Jul 27, 2021 

--- FAIL: TestGethClient (0.01s)

    --- FAIL: TestGethClient/TestAccessList (0.00s)

        gethclient_test.go:146: unexpected error: failed to apply transaction: 0xf1896776ada91d0cbcc861fac937cd06b86aba11cc55ba1fb264188e41e9dbbf err: max fee per gas less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, maxFeePerGas: 1 baseFee: 765625000

MariusVanDerWijden
MariusVanDerWijden commented Jul 27, 2021
View reviewed changes
core/vm/access_list_tracer.go
@@ -96,7 +96,7 @@ func (al accessList) equal(other accessList) bool {
func (al accessList) accessList() types.AccessList {
acl := make(types.AccessList, 0, len(al))
for addr, slots := range al {
tuple := types.AccessTuple{Address: addr}
tuple := types.AccessTuple{Address: addr, StorageKeys: []common.Hash{}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue where sometimes the AL tracer would produce an accesslist with nil StorageKeys. This would then fail the marshaling/unmarshaling

@holiman holiman merged commit 2faf796 into ethereum:master Jul 28, 2021
@holiman holiman added this to the 1.10.7 milestone Jul 28, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Jul 28, 2021
@MariusVanDerWijden @holiman
internal/ethapi: fix panic in accesslist creation (ethereum#23225)
ca87d60 
* internal/ethapi: revert + fix properly in al tracer

* internal/ethapi: use toMessage instead of creating new message

* internal/ethapi: remove ineffassign

* core: fix invalid unmarshalling, fix test

Co-authored-by: Martin Holst Swende <martin@swende.se>
reds pushed a commit to reds/go-ethereum that referenced this pull request Aug 28, 2021
@MariusVanDerWijden @holiman
internal/ethapi: fix panic in accesslist creation (ethereum#23225)
7087ae6 
* internal/ethapi: revert + fix properly in al tracer

* internal/ethapi: use toMessage instead of creating new message

* internal/ethapi: remove ineffassign

* core: fix invalid unmarshalling, fix test

Co-authored-by: Martin Holst Swende <martin@swende.se>
i-norden pushed a commit to cerc-io/go-ethereum that referenced this pull request Sep 10, 2021
@MariusVanDerWijden @holiman @i-norden
internal/ethapi: fix panic in accesslist creation (ethereum#23225)
8fa55e1 
* internal/ethapi: revert + fix properly in al tracer

* internal/ethapi: use toMessage instead of creating new message

* internal/ethapi: remove ineffassign

* core: fix invalid unmarshalling, fix test

Co-authored-by: Martin Holst Swende <martin@swende.se>
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@MariusVanDerWijden @holiman @atif-konasl
internal/ethapi: fix panic in accesslist creation (ethereum#23225)
8a37966 
* internal/ethapi: revert + fix properly in al tracer

* internal/ethapi: use toMessage instead of creating new message

* internal/ethapi: remove ineffassign

* core: fix invalid unmarshalling, fix test

Co-authored-by: Martin Holst Swende <martin@swende.se>
@MariusVanDerWijden MariusVanDerWijden deleted the fix-al-crash branch November 30, 2021 15:26
This was referenced Sep 23, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 rjl493456442 left review comments

@ramaaz31 ramaaz31 ramaaz31 approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.7
Development

Successfully merging this pull request may close these issues.

eth_createAccessList handler crashed
4 participants
@MariusVanDerWijden @holiman @rjl493456442 @ramaaz31