Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: crash casued by no limits for rewardPercentiles at interface FeeHistory #29709

Closed
buddh0 opened this issue May 6, 2024 · 1 comment
Labels

Comments

@buddh0
Copy link
Contributor

buddh0 commented May 6, 2024

there is no number limit for rewardPercentiles
when maxBlockHistory set to 1024,
then set 600k element(limited by rpc requtest size) in rewardPercentiles to call FeeHistory
the node will crash, for too many memory need.

maybe only a few nodes set maxBlockHistory such a big number,
but I think It's better to limit the number of rewardPercentiles to defend attack.
so, please check this PR eth/gasprice: add query limit for FeeHistory to defend DDOS attack again, thx.

@buddh0 buddh0 added the type:bug label May 6, 2024
@karalabe
Copy link
Member

karalabe commented May 7, 2024

Merged, thx

@karalabe karalabe closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants