Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of genesis/terminalTotalDifficultyPassed #29555

Open
karalabe opened this issue Apr 16, 2024 · 2 comments
Open

Get rid of genesis/terminalTotalDifficultyPassed #29555

karalabe opened this issue Apr 16, 2024 · 2 comments
Labels
type:feature

Comments

@karalabe
Copy link
Member

Since Geth v1.14 can only run in post-merge mode, we can just assume that all networks are like that and don't even bother with checking? Tho perhaps we can leave the flag in the genesis for a major version and then remove it? Needs a bit of thought.
@karalabe
Copy link
Member Author

Just a small triage update. We kind of all agree to remove this field, but maybe wait 1-2-3 small releases just to have time to phase out pre-merge networks.

@karalabe
Copy link
Member Author

Support for non merge networks is being dropped in 1.14 (#29169), so this issue should be "fixed" in light of that timing wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karalabe