New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling PragueTime causes the chain to not "seal" #29190
Comments
Did not mean to add type:docs. Definitelly not a doc issue. |
Engine API spec says GetPayloadV3 can only be called during Cancun :)
So the question is whether Prague is expected to introduce a new GetPayload version or if the spec will need to allow V3 to run during Prague too. As is, Geth if conforming to the specs :) |
Just to make sure, there are no plan to fix that, and make Prague "usable" ? What are the recommandations for testing Prague candidates ? Marking them as Cancun to bypass that and run them in an cancun dev chain doesn't sound right to me. |
Prague uses |
Maybe I was too quick closing this |
So, if api.eth.BlockChain().Config().LatestFork(params.Timestamp) != forks.Cancun {
return engine.PayloadStatusV1{Status: engine.INVALID}, engine.UnsupportedFork.With(errors.New("newPayloadV3 must only be called for cancun payloads"))
} And Not sure how to best resolve this. Since a new payload format for Prague is not yet specified (afaik), I think the simplest would be to just accept Prague too: if current := api.eth.BlockChain().Config().LatestFork(params.Timestamp); current != forks.Cancun && current != forks.Prague {
return engine.PayloadStatusV1{Status: engine.INVALID}, engine.UnsupportedFork.With(errors.New("newPayloadV3 must only be called for cancun payloads"))
} |
I noticed that the on the master, enabling prague causes the chain to behave strangely.
How to replicate:
params/config.go
to addPragueTime: newUint64(0),
inAllDevChainProtocolChanges
make geth && ./build/bin/geth --dev --http --http.api eth,web3,net
I am getting this log
I understand Prague is still pretty much WIP, but this error is affecting testing of candidate EIP.
The text was updated successfully, but these errors were encountered: