Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh completion not working #29080

Open
Xeonacid opened this issue Feb 25, 2024 · 3 comments
Open

zsh completion not working #29080

Xeonacid opened this issue Feb 25, 2024 · 3 comments
Assignees
Labels

Comments

@Xeonacid
Copy link

Xeonacid commented Feb 25, 2024

System information

Geth version: 1.13.13-stable
OS & Version: Linux Ubuntu 22.04

Expected behaviour

Type geth then press Tab, a command completion is listed.

Actual behaviour

Files in cwd is listed, acting same as without a completion.

But if run source /usr/share/zsh/vendor-completions/_geth manually, it works fine like a charm.

Steps to reproduce the behaviour

sudo add-apt-repository ppa:ethereum/ethereum
sudo apt install geth

In zsh, type geth then press Tab, files in cwd is listed.

Other command completions in /usr/share/zsh/vendor-completions work fine.

Run source /usr/share/zsh/vendor-completions/_geth and try again, completion works fine.

cc @willianpaixao

@hashworks
Copy link

Note: This only affects the ZSH completion, the BASH completion is sourced automatically as one would expect.

@willianpaixao
Copy link
Contributor

Thanks for reporting, @Xeonacid. At the moment of writing I'm not in my computer but will test it later.
That said, it looks like Zsh is not automatically sourcing that file, just stating the obvious. Which makes me think it's a Zsh issue and not Geth.

@Xeonacid
Copy link
Author

Xeonacid commented Feb 26, 2024

That said, it looks like Zsh is not automatically sourcing that file, just stating the obvious. Which makes me think it's a Zsh issue and not Geth.

But any other file in the same folder (/usr/share/zsh/vendor-completions) is automatically sourced and completion works fine. I'm not a zsh expert and have no idea about what's wrong. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants