Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_feeHistory crashes with "finalized" block specifier #25671

Closed
jdevcs opened this issue Sep 2, 2022 · 2 comments
Closed

eth_feeHistory crashes with "finalized" block specifier #25671

jdevcs opened this issue Sep 2, 2022 · 2 comments
Assignees
Milestone

Comments

@jdevcs
Copy link

jdevcs commented Sep 2, 2022

Geth method handler crashed on getFeeHistory with finalized tag:

curl --location --request POST 'http://node.addr' \ --header 'Content-Type: application/json' \ --data-raw '{ "method": "eth_feeHistory", "params": [ "0x4", "finalized", [ 25, 50, 75 ] ], "id": 1, "jsonrpc": "2.0" }'

returning
{ "jsonrpc": "2.0", "id": 1, "error": { "code": -32000, "message": "method handler crashed" } }

Geth version: Geth/v1.10.21-omnibus-6399bbf3/linux-amd64/go1.18.4

@jdevcs
Copy link
Author

jdevcs commented Sep 2, 2022

Tested on Goerli NW

@fjl fjl added this to the 1.11.0 milestone Sep 6, 2022
@fjl fjl changed the title Method handler crashed - getFeeHistory eth_feeHistory crashes with "finalized" block specifier Sep 6, 2022
@holiman
Copy link
Contributor

holiman commented Sep 26, 2022

Git bisect shows that was fixed as of a0b88ce , with #25442

@holiman holiman closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@fjl @holiman @lightclient @jdevcs and others