core: ignore basefee when comparing with pool gasprice in txpool #24080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XWJACK
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
changed the title
fjl
reviewed
Dec 16, 2021
| pendingBaseFee := pool.priced.urgent.baseFee | ||
| if !local && tx.EffectiveGasTipIntCmp(pool.gasPrice, pendingBaseFee) < 0 { | ||
| // Drop non-local transactions under our own minimal accepted gas price or tip | ||
| if !local && tx.GasTipCapIntCmp(pool.gasPrice) < 0 { |
There was a problem hiding this comment.
I think it should be GasFeeCapIntCmp here.
There was a problem hiding this comment.
After some more discusssion, it seems just reverting to GasTipCapIntCmp is the best choice for now.
There was a problem hiding this comment.
WHY？I think tx.EffectiveGasTipIntCmp(pool.gasPrice, pendingBaseFee) < 0 Is better here.
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Dec 19, 2021
…ereum#24080) This reverts commit 9489853.
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…ereum#24080) This reverts commit 9489853.
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #24079
pool.gasPriceis config bypricelimit.go-ethereum/core/tx_pool.go
Line 300 in cc87cbd
baseFeewill always changed by tx pool . so if you do that, users will not able to send tx below baseFee rather thanpricelimit. highly recommended revert this pr #23855.go-ethereum/core/tx_list.go
Line 424 in cc87cbd
#23855
#23837