New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth/catalyst: implement kintsugi-spec v3 #24067
Conversation
f1ea7ea
to
b427143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So essentially the MergeForkBlock
is set as usual fork block, but indicates "we are starting the transition right now, but transition will happen in the next a few blocks"?
From the spec
I don't see that being done in this PR? |
Yes, I have a follow-up PR that implements the RANDOM opcode which will also do the changes needed for mixhash |
Yes exactly, it should just help us to kick off unwanted nodes early from, rather than connecting to them and then yeeting them later on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code int | ||
Message string | ||
Code int | ||
ValidationError string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error type is kind of misplaced in package rpc. I'm merging anyway, but please move it in the next iteration.
This PR implements kintsugi-spec v3 (with engine api version v1.0.0-alpha.5)
A rundown of all changes can be found here: https://hackmd.io/@n0ble/kintsugi-spec
It includes a new fork block
MergeForkBlock
which should be updated before TTD is reached.This
MergeForkBlock
is only used for the forkID calculation, nothing else.This is a block that should happen before the merge to fork non-merge ready nodes off the network.