core/vm: don't use iota for opcode definitions #23928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 23, 2021
core/vm: don't use iota for opcode definitions
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 26, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a pet peeve I've had for years.
iotais useful when we don't really care what number something winds up with, we just want an enum-like thing which has a certain ordering between elements.Opcodes, however, are externally defined. It's IMO wrong to assign them by using
iota, as if we don't really care what numberCALLmaps to internally.Aside from that, having it directly defined as in this PR makes it easier to check a particular opcode-to-byte with eyes alone, without relying on IDE magic to infer the actual number for you.