eth_getTransactionByHash return 0x0 sender value for pending EIP-1559 tx

[nining]

System information

Geth version: v1.10.10
OS & Version: Linux

Expected behaviour

return correct tx sender address

Actual behaviour

return 0x0

Steps to reproduce the behaviour

for any pending EIP-1559 tx

example result:
{
  "nonce": "0x1",
  "hash": "0x18aadbf8d2107a47315da9178590ef29d8f35fb67386c26eaddd051d5c6d4e80",
  "gas": "0x5208",
  "blockNumber": null,
  "gasPrice": "0xc92a69c00",
  "from": "0x0000000000000000000000000000000000000000",
  "blockHash": null,
  "transactionIndex": null,
  "value": "0xe54aeefe8c000",
  "to": "0xa4e5961b58dbe487639929643dcb1dc3848daf5e",
  "s": "0xe35fa2f48b524198048ab4eeb21c7a0c4d1c7858fac0a365e9a8c17ccc1ceab",
  "r": "0xc24b399f68566789de62a1b4a3f2b6dee0ee1337f53ad94387a184533e00a9d3",
  "v": "0x26",
  "input": "0x",
  "type": "0x0"
}

[nining]

This bug might caused by this merge:
#23683 internal/ethapi: use correct signer when serving old blocks

[MariusVanDerWijden]

The v value looks off to me, is this transaction on mainnet?

[MariusVanDerWijden]

func TestMakeSigner(t *testing.T) {
	gp, _ := new(big.Int).SetString("0xc92a69c00", 0)
	val, _ := new(big.Int).SetString("0xe54aeefe8c000", 0)
	v, _ := new(big.Int).SetString("0x26", 0)
	r, _ := new(big.Int).SetString("0xc24b399f68566789de62a1b4a3f2b6dee0ee1337f53ad94387a184533e00a9d3", 0)
	s, _ := new(big.Int).SetString("0xe35fa2f48b524198048ab4eeb21c7a0c4d1c7858fac0a365e9a8c17ccc1ceab", 0)
	to := common.HexToAddress("0xa4e5961b58dbe487639929643dcb1dc3848daf5e")
	tx := LegacyTx{
		Nonce:    1,
		GasPrice: gp,
		To:       &to,
		Gas:      0x5208,
		Value:    val,
		V:        v,
		R:        r,
		S:        s,
	}
	typeTx := NewTx(&tx)
	fmt.Printf("hash: %v", typeTx.Hash())
	signer := HomesteadSigner{}
	sender, err := signer.Sender(typeTx)
	if err != nil {
		panic(err)
	}
}

Results in

hash: 0x18aadbf8d2107a47315da9178590ef29d8f35fb67386c26eaddd051d5c6d4e80--- FAIL: TestMakeSigner (0.00s)
panic: invalid transaction v, r, s values [recovered]
	panic: invalid transaction v, r, s values

So the type in the log says it is a LegacyTx not a DynamicFeeTx. If I put it as a LegacyTx I receive the correct hash. Are you sure that the signature is valid?

[nining]

The v value looks off to me, is this transaction on mainnet?

it was dropped: https://etherscan.io/tx/0x18aadbf8d2107a47315da9178590ef29d8f35fb67386c26eaddd051d5c6d4e80

You can choose pending tx from https://etherscan.io/txsPending. If it was still pending when calling eth_getTransactionByHash, then the result "from" field would be "0x0000000000000000000000000000000000000000"

[MariusVanDerWijden]

I found and fixed the issue here: #23765