Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken web3 methods link in README.md #23703

Merged
merged 1 commit into from Oct 12, 2021
Merged

fixed broken web3 methods link in README.md #23703

merged 1 commit into from Oct 12, 2021

Conversation

z89
Copy link
Contributor

@z89 z89 commented Oct 11, 2021

PR to fix the 'web3 methods' broken link in README.md, https://web3js.readthedocs.io/en/ results in a 404, so I included the latest version v1.5.2 before the latest release candidate v3.0.0-rc.5

README.md Outdated Show resolved Hide resolved
@z89 z89 requested a review from gballet October 12, 2021 05:07
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indeed, as @s1na correctly points out, the antiquated version we use is not going to match this link, but readthedocs doesn't have the target version, so an incorrect version is better than having a dead link.

@gballet gballet merged commit 3d11a22 into ethereum:master Oct 12, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants