New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: race condition in dialer scheduler #23430
Comments
Hmm that is not latest master afaict. Could you link the commit you're using? |
I fixed some races here: #23434 |
The race in this issue is on |
My bad , was latest master off bsc and should have written the description @fjl wrote , yes that’s the problem - |
I'm actually not sure how to fix this race correctly. The check on |
Agree - it wasn’t clear to me how to fix it immediately either , and don’t want locks for just this - if node being removed anyway then .dest being updated shouldn’t be needed then |
This issue has become quite stale now. I can't reproduce the race condition anymore. Feel free to reopen if this is still an issue with the current master. |
I'm sure this race is not fixed. It's just hard to reproduce because it requires resolving the node, which takes variable time. |
@fjl how about solving it by just making it an atomic.Pointer? |
Yeah I guess this would be a possible fix. Though I think there must be a better way to fix it. The main issue is really just that the main loop wants access to the node ID, and it reads that through |
off of latest master -
The text was updated successfully, but these errors were encountered: