Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer/core/apitypes: remove dependency on internal/ethapi #23362

Merged
merged 1 commit into from Aug 23, 2021

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Aug 9, 2021

For #23046

@fjl fjl requested a review from holiman as a code owner August 9, 2021 09:42
@fjl fjl added this to the 1.10.8 milestone Aug 10, 2021
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit bb1f7eb into ethereum:master Aug 23, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 23, 2021
reds pushed a commit to reds/go-ethereum that referenced this pull request Aug 28, 2021
i-norden pushed a commit to cerc-io/go-ethereum that referenced this pull request Sep 10, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants