Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: multiple personas clickable on list of wallets #12645

Open
1 of 2 tasks
konopkja opened this issue Apr 3, 2024 · 8 comments · May be fixed by #12753
Open
1 of 2 tasks

Feature request: multiple personas clickable on list of wallets #12645

konopkja opened this issue Apr 3, 2024 · 8 comments · May be fixed by #12753
Assignees
@bhargavkakadiya
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@konopkja
Copy link
Contributor

konopkja commented Apr 3, 2024 •
edited

Is your feature request related to a problem? Please describe.

With rising popularity of personas, during user testing several users requested having the option to select multiple personas to filter down list of wallets to a narrower list that tailors to their needs.

https://ethereum.org/en/wallets/find-wallet/

Screenshot 2024-04-03 at 12 03 04

Describe the solution you'd like

Switch logic to "AND" and allow users to select multiple personas.

Change radio buttons to checkboxes in UI

Describe alternatives you've considered

NA

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@konopkja konopkja added feature ✨ This is enhancing something existing or creating something new dev required This requires developer resources labels Apr 3, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Apr 3, 2024
@bhargavkakadiya
Copy link
Contributor

bhargavkakadiya commented Apr 3, 2024 •
edited

@konopkja I would like to contribute to this

@konopkja
Copy link
Contributor Author

konopkja commented Apr 3, 2024

Hi @bhargavkakadiya, thank you for your interest in this task! I will assign it to you and pinging @pabloped and @nhsz to provide guidance on implementation if needed.

@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Apr 8, 2024
@konopkja
Copy link
Contributor Author

Hi @bhargavkakadiya, are you still interested working on this issue?

@bhargavkakadiya
Copy link
Contributor

@konopkja Yes I am interested
I have made progress with multi select UI, please give me until this week to try fixing display of wallets based on the select options

@konopkja
Copy link
Contributor Author

@konopkja Yes I am interested I have made progress with multi select UI, please give me until this week to try fixing display of wallets based on the select options

Of course! Thank you for working on this! I was just curious about status update and seeing whether you need any help guidance to finish this. If so please let us know and we will gladly help :)

I think this might be a more complex feature that it seems on first sight.

@bhargavkakadiya
Copy link
Contributor

bhargavkakadiya commented Apr 15, 2024 •
edited

@konopkja yes, it's a slightly tough given the filtering structure used right now is supported for single select options
Thanks for offering the help, I can of course post questions here but I was wondering if you also discuss issues on discord?

@konopkja
Copy link
Contributor Author

@konopkja yes, it's a slightly tough given the filtering structure used right now is supported for single select options Thanks for offering the help, I can of course post questions here but I was wondering if you also discuss issues on discord?

ethereum.org has public discord with a dedicated website-code channel where others can chime in (i am mysel designer so cant help that much). The discord invite link is in the footer of our website.

bhargavkakadiya added a commit to bhargavkakadiya/ethereum-org-website that referenced this issue Apr 17, 2024
@bhargavkakadiya
multiple personas clickable [Fixes ethereum#12645]
3b065ba
@wackerow wackerow linked a pull request Apr 18, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhargavkakadiya bhargavkakadiya

Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multiple personas clickable [Fixes #12645] bhargavkakadiya/ethereum-org-website
3 participants
@bhargavkakadiya @wackerow @konopkja