Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up bitarray dependency to allow <3 #163

Merged
merged 1 commit into from May 20, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented May 20, 2022

What was wrong?

Some users were have trouble installing web3.py because of the strict bitarray dependency requirement. In v2.4.0 bitarray added wheels for all platform types, which should fix the issue. This is the backwards compatible change, and the non-backwards compatible change (>=2.4,<3) was PRed against master.

Issue #154, #159

How was it fixed?

See above.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@kclowes kclowes merged commit 53400cb into ethereum:v0.5.x May 20, 2022
@kclowes kclowes deleted the open-bitarray-dep branch May 20, 2022 20:24
@kclowes kclowes mentioned this pull request Jun 6, 2022
kasperski95 pushed a commit to software-mansion/protostar that referenced this pull request Sep 2, 2022
Bumps [eth-account](https://github.com/ethereum/eth-account) from 0.5.7 to 0.5.9.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ethereum/eth-account/blob/master/docs/release_notes.rst">eth-account's changelog</a>.</em></p>
<blockquote>
<h2>eth-account v0.5.9 (2022-08-04)</h2>
<p>Bugfixes</p>
<pre><code>
- fix DoS-able regex pattern (`[#178](ethereum/eth-account#178) &lt;https://github.com/ethereum/eth-account/issues/178&gt;`__)
<p>Miscellaneous changes
</code></pre></p>
<ul>
<li><code>[#183](ethereum/eth-account#183) &lt;https://github.com/ethereum/eth-account/issues/183&gt;</code><strong>, <code>[#184](ethereum/eth-account#184) &lt;https://github.com/ethereum/eth-account/issues/184&gt;</code></strong></li>
</ul>
<h2>eth-account v0.5.8 (2022-06-06)</h2>
<p>Miscellaneous changes</p>
<pre><code>
- `[#163](ethereum/eth-account#163) &lt;https://github.com/ethereum/eth-account/issues/163&gt;`__, `[#168](ethereum/eth-account#168) &lt;https://github.com/ethereum/eth-account/issues/168&gt;`__
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/ethereum/eth-account/commit/c0060ca25e8461b9622eab318d922c0a48e8d5a8"><code>c0060ca</code></a> Bump version: 0.5.8 → 0.5.9</li>
<li><a href="https://github.com/ethereum/eth-account/commit/da84e6db056f77632d5ff5a5ec7c3fb04e488586"><code>da84e6d</code></a> Compile release notes</li>
<li><a href="https://github.com/ethereum/eth-account/commit/891ec7cfa2351433a44e13924361380136c2cd6a"><code>891ec7c</code></a> Allow bumpversion to find version (<a href="https://github-redirect.dependabot.com/ethereum/eth-account/issues/184">#184</a>)</li>
<li><a href="https://github.com/ethereum/eth-account/commit/f1ee53297593fde87b223e7176009baff11b6735"><code>f1ee532</code></a> Update mypy version (<a href="https://github-redirect.dependabot.com/ethereum/eth-account/issues/183">#183</a>)</li>
<li><a href="https://github.com/ethereum/eth-account/commit/70f89be700df0d5f08ef696252c88741f8414060"><code>70f89be</code></a> fix redos-able regex and add poc code to tests (<a href="https://github-redirect.dependabot.com/ethereum/eth-account/issues/182">#182</a>)</li>
<li><a href="https://github.com/ethereum/eth-account/commit/d8f88e78dab1c122d76531125d5a1156108e5303"><code>d8f88e7</code></a> Bump version: 0.5.7 → 0.5.8</li>
<li><a href="https://github.com/ethereum/eth-account/commit/424bebc9bf42ed22b15753d60fb3f740541ef8d3"><code>424bebc</code></a> Compile release notes</li>
<li><a href="https://github.com/ethereum/eth-account/commit/0b2e5a5b3f5fdae20c6e6c569078467fc0ae28b2"><code>0b2e5a5</code></a> Allow wider range of towncrier again, exclude venv/ files from distribution (...</li>
<li><a href="https://github.com/ethereum/eth-account/commit/53400cba76f9b3cb4e108b75c46d8ad099208dbc"><code>53400cb</code></a> Open up bitarray dependency to allow &lt;3 (<a href="https://github-redirect.dependabot.com/ethereum/eth-account/issues/163">#163</a>)</li>
<li>See full diff in <a href="https://github.com/ethereum/eth-account/compare/v0.5.7...v0.5.9">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eth-account&package-manager=pip&previous-version=0.5.7&new-version=0.5.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/software-mansion/protostar/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants