Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the need for bitarray dependency or update version #132

Closed
fselmo opened this issue Oct 6, 2021 · 14 comments
Closed

Investigate the need for bitarray dependency or update version #132

fselmo opened this issue Oct 6, 2021 · 14 comments

Comments

@fselmo
Copy link
Contributor

fselmo commented Oct 6, 2021

What was wrong?

... and many cases on Discord

It seems to only be used in hdaccount support. We should investigate if we can remove this dependency while still supporting hdaccount logic.

How can it be fixed?

  1. Can we somehow remove bitarray dependency and keep hdaccount support?
  2. Does updating the bitarray version resolve these issues?

I'm not confident in option 2 as I believe some users also tried to manually pip install bitarray and also had issues but I have not looked too far into this so I'll leave this option up.

@fselmo fselmo changed the title Investigate the need for bitarray dependency / or update version Investigate the need for bitarray dependency or update version Oct 6, 2021
@kclowes
Copy link
Collaborator

kclowes commented Oct 6, 2021

This commit is where it got added for reference.

@Kaditcuy
Copy link

Kaditcuy commented Apr 2, 2022

you just need to install bitarray==1.2.2 and it works
I tried this and it didn't work, then I tried the latest version of Bitarray 2.4.1, which also didn't work.

@Bruce95317
Copy link

tried the method mentioned above , still error

Collecting bitarray==1.2.2
Using cached bitarray-1.2.2.tar.gz (48 kB)
Preparing metadata (setup.py) ... done
Building wheels for collected packages: bitarray
Building wheel for bitarray (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [13 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-3.8
creating build\lib.win-amd64-3.8\bitarray
copying bitarray\test_bitarray.py -> build\lib.win-amd64-3.8\bitarray
copying bitarray\test_util.py -> build\lib.win-amd64-3.8\bitarray
copying bitarray\util.py -> build\lib.win-amd64-3.8\bitarray
copying bitarray_init_.py -> build\lib.win-amd64-3.8\bitarray
running build_ext
building 'bitarray._bitarray' extension
error: [WinError 2] The system cannot find the file specified
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for bitarray
Running setup.py clean for bitarray
Failed to build bitarray
Installing collected packages: bitarray
Running setup.py install for bitarray ... error
error: subprocess-exited-with-error

× Running setup.py install for bitarray did not run successfully.
│ exit code: 1
╰─> [13 lines of output]
running install
running build
running build_py
creating build
creating build\lib.win-amd64-3.8
creating build\lib.win-amd64-3.8\bitarray
copying bitarray\test_bitarray.py -> build\lib.win-amd64-3.8\bitarray
copying bitarray\test_util.py -> build\lib.win-amd64-3.8\bitarray
copying bitarray\util.py -> build\lib.win-amd64-3.8\bitarray
copying bitarray_init_.py -> build\lib.win-amd64-3.8\bitarray
running build_ext
building 'bitarray._bitarray' extension
error: [WinError 2] The system cannot find the file specified
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> bitarray

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

@mebedel
Copy link

mebedel commented Apr 2, 2022

My solution does not work!

I think I know what’s the problem
First i installed win c build tools
Then checked bit array version used by web3 package
afterwards I deleted win c build tools
And did as mentioned by my first post
I think that, what got installed by the build tools didn’t get fully deleted
And that’s why it worked for me but not for you and i am using python 3.10 also
I'll check more when I get to my pc

My solution does not work!

@Noob-A
Copy link

Noob-A commented May 30, 2022

Still doesn't work

@fselmo
Copy link
Contributor Author

fselmo commented Jun 7, 2022

Option 2 outlined here has been released on v0.5.8 via #163 and will be released on v.0.6.2 via #154. The latest versions of bitarray (v2.4.0+) should have the wheels for different platforms and updating bitarray to one of these latest versions can hopefully help to resolve these issues.

I'll keep this open for now so we can keep monitoring and see if things have improved.

@pietrodn
Copy link

Still waiting for the 0.6.2 release, this is forcing me to use a bigger Docker version with the GCC compiler.

@kclowes
Copy link
Collaborator

kclowes commented Aug 17, 2022

@pietrodn you should be able to use 0.5.8+ or 0.7.0. We have a security fix that got released in 0.5.9 so I'd recommend using that or higher if you're on the 0.5.x versions. I'm going to close this because I believe this should be fixed with the two releases mentioned above.

@kclowes kclowes closed this as completed Aug 17, 2022
@pietrodn
Copy link

Unfortunately the web3 library I'm using requires eth-account >=0.6.0,<0.7.0 😞

@kclowes
Copy link
Collaborator

kclowes commented Aug 22, 2022

@pietrodn out of curiosity, which library are you using?

@pietrodn
Copy link

@kclowes
Copy link
Collaborator

kclowes commented Aug 22, 2022

@pietrodn what version?

@pietrodn
Copy link

6.0.0b4 (I need asyncio support)

@kclowes
Copy link
Collaborator

kclowes commented Aug 22, 2022

got it. I'm working on that now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants