Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

chore: Update PayloadID type to upstream geth core.beacon.PayloadID #218

Closed
norswap opened this issue Mar 2, 2022 · 4 comments
Closed

Comments

@norswap
Copy link
Contributor

norswap commented Mar 2, 2022

See comment here: #127 (comment)

The type is now merged in geth (it's here: https://github.com/ethereum/go-ethereum/blob/20356e57b119b4e70ce47665a71964434e15200d/core/beacon/types.go)

This involves:

  • rebasing our geth fork on top of geth 1.10.16
  • updataing the imports
  • changing the types
@norswap
Copy link
Contributor Author

norswap commented Mar 2, 2022

@protolambda does that look good? Want to do it? I'll do if necessary, just let me know.

@protolambda
Copy link
Collaborator

protolambda commented Mar 2, 2022

There are other Engine API changes (mostly renames, and subtle effects to execution-layer syncing) that we'll also need to adopt if we rebase our geth diff on the latest version. For now I would prioritize keeping open sequencing PRs + blobs EIP moving. I could do the rebase/integration of latest geth after that.

@norswap
Copy link
Contributor Author

norswap commented Mar 3, 2022

Yes, I should have clarified, but this is not urgent. It was just in one my of my todo lists, and I thought I'd get it in the proper location :)

@protolambda
Copy link
Collaborator

Closing this, this was implemented upstream long ago here: ethereum/go-ethereum#24236 and we use the type already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants