[release-3.5] fix the flaky test TestV3AuthRestartMember #14454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr
changed the title
|
Thanks @ahrtr , the test isn't so flaky in release-3.5 and main, but it's good to have the change in the branches. I'll merge after getting reply to this comment in the other PR: #14453 (comment) (for making sure that we have no special reasons not to merge it) |
serathius
approved these changes
Sep 13, 2022
|
Thanks both @serathius and @mitake for the quick review. Let me merge this PR firstly. Will rework #14453 later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Wang wachao@vmware.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @serathius @mitake @spzala
Please also review #14453