Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.5] Revert #13714 #13950

Merged
merged 2 commits into from Apr 19, 2022
Merged

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 15, 2022

Reverts the PR #13714 and adds a unit test for correct handling of canonical SRV records.

xref #13948 and master revert PR #13949

/cc @serathius @spzala @ahrtr

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liggitt
cc @serathius

@liggitt
Copy link
Contributor Author

liggitt commented Apr 18, 2022

not sure what to do here to bump the tests to retry... none of the test failures look related to this revert

@spzala
Copy link
Member

spzala commented Apr 18, 2022

not sure what to do here to bump the tests to retry... none of the test failures look related to this revert

@liggitt sorry, unfortunately there are test flakes. The semaphoreci is a known issue.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you.

Please refer to the discussion in issues/13948

@ptabor ptabor merged commit b872757 into etcd-io:release-3.5 Apr 19, 2022
@serathius serathius changed the title Revert #13714 [release-v3.5] Revert #13714 Apr 19, 2022
@serathius serathius mentioned this pull request Apr 19, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants