Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to release bbolt 1.4.0 #553

Open
ahrtr opened this issue Aug 14, 2023 · 6 comments
Open

Plan to release bbolt 1.4.0 #553

ahrtr opened this issue Aug 14, 2023 · 6 comments
Milestone

Comments

@ahrtr
Copy link
Member

ahrtr commented Aug 14, 2023

Some notable changes in bbolt 1.4.0:

  • Code refactoring, e.g moving some common logic into package internal/common;
  • Big improvement on the surgery commands;
  • Add logger into bbolt;
  • Some performance improvements;

Please see the complete changes to be included in 1.4.0 in milestone 1.4.0.

Note that etcd 3.6.0 will depend on bbolt 1.4.0. Previously I mentioned that etcd 3.6.0 will depend on bbolt 1.3.8, it is a typo. I already updated the ticket #542, sorry for the confusion. etcd 3.4 and 3.5 will continue to depend on bbolt 1.3.x.

We need to cut branch release-1.4, based on which the bbolt 1.4.0 will be released. Afterwards, it only accepts bug fixes, and any feature changes will only be merged into the master branch.

@mitake @ptabor @serathius @spzala @wenjiaswe @tjungblu @cenkalti @fuweid @jmhbnz

@ahrtr
Copy link
Member Author

ahrtr commented Aug 16, 2023

Rough plan:

  • Release 1.4.0-alpha.0 after the following tickets are done. Will not cut branch, and it will be released against the master branch.
  • Continuously testing bbolt 1.4.0-alpha.0 in etcd.
  • [Optional] Release 1.4.0-beta.X if there are any major issues.
  • Cut branch release-1.4 and release 1.4.0-rc.X or 1.4.0.

@jo-chemla
Copy link

Quick question: is it possible to use the bbolt 1.4.0 release before the actual release without building myself? Just tried this command with no luck:

# v1.4.0 Not found
go install go.etcd.io/bbolt/cmd/bbolt@v1.4.0
go: go.etcd.io/bbolt/cmd/bbolt@1.4.0: go.etcd.io/bbolt/cmd/bbolt@1.4.0: invalid version: unknown revision 1.4.0

Edit: It seems that this command does exactly this, downloading bbolt latest master branch, although version command says it is version 1.3.7, which does make sense.

# seem to download 1.3.7 but bbolt version command seem to work, 
C:\portainer>go install go.etcd.io/bbolt/cmd/bbolt@master
go: downloading go.etcd.io/bbolt v1.3.7-0.20231025151518-d094cd712c9a

C:\portainer>bbolt version
bbolt Version: 1.3.7
Go Version: go1.21.3
Go OS/Arch: windows/amd64

@ahrtr
Copy link
Member Author

ahrtr commented Jan 10, 2024

I am planning to create tag 1.4.0-alpha.0 this week per plan above #553 (comment). Please let me know if anyone has any comment or concern.

@ahrtr
Copy link
Member Author

ahrtr commented Jan 12, 2024

Tag v1.4.0-alpha.0 was just created.

@github-actions github-actions bot added the stale label Apr 16, 2024
@ahrtr
Copy link
Member Author

ahrtr commented May 3, 2024

Planning to release v1.4.0-alpha.1

Please read #745 to get all the changes since 1.4.0-alpha.0

@ahrtr
Copy link
Member Author

ahrtr commented May 6, 2024

Tag v1.4.0-alpha.1 was created.

@ahrtr ahrtr removed the stale label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants