Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws encryptionConfiguration not being set with KMS #598

Open
bdjtcg opened this issue Sep 18, 2023 · 0 comments
Open

aws encryptionConfiguration not being set with KMS #598

bdjtcg opened this issue Sep 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bdjtcg
Copy link

bdjtcg commented Sep 18, 2023

I am trying to enable KMS encryption and have set the following in the config, however repositories are still being created with AES-256. :

target:
  aws:
    accountId: "123456"
    ecrOptions:
      encryptionConfiguration:
        encryptionType: "KMS"
        kmsKey: "arn:aws:kms:us-west-2:123456"
    region: us-west-2

No errors are logged. Please let me know if anyone has successfully set kms encryption. Any help is appreciated.
Also, I noticed there is no reference to encryptionConfiguration in the ecr.go.80:

client := &ECRClient{
		client:          ecrClient,
		ecrDomain:       ecrDomain,
		cache:           cache,
		scheduler:       scheduler,
		targetAccount:   clientConfig.AccountID,
		accessPolicy:    clientConfig.ECROptions.AccessPolicy,
		lifecyclePolicy: clientConfig.ECROptions.LifecyclePolicy,
		tags:            clientConfig.ECROptions.Tags,
	}
@estahn estahn self-assigned this Feb 27, 2024
@estahn estahn added the bug Something isn't working label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants