-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This crate does not work with the new workspace dependencies #140
Comments
When using [package]
version.workspace = true in a workspace crate, I'm getting
with both a nightly from 1.64 ( |
I can confirm latest version works with workspace deps |
It would be nice to have a test for this. |
@woshilapin yeah I have botched that update a little, unfortunately, forgot to check in the lockfile changes. As there is a Rust release next week however, there would also be a new cargo release, which means that it's also time for a new cargo-udeps release. The train model definitely has its advantages :). |
0.1.35 is out: https://github.com/est31/cargo-udeps/releases/tag/v0.1.35 |
@est31 It does work when you reference a lib from the root Cargo.toml in another project in your workspace and it is not used. However, libs that are inside the root Cargo.toml file but nowhere referenced in other projects in the workspace are not picked up. Can this be fixed? |
@Jasperav that's interesting, thanks for the feedback. I guess it should be possible to support that, it's more of a feature request than a bug however. The reason why I'm keeping this issue open is because there is no test yet for unused workspace dependencies that cargo builds. |
The new workspace deps feature is explained here: https://betterprogramming.pub/workspace-inheritance-in-rust-65d0bb8f9424
Reproduction path:
The text was updated successfully, but these errors were encountered: