Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new typeguard version #5660

Closed
albertz opened this issue Feb 14, 2024 · 3 comments
Closed

Support for new typeguard version #5660

albertz opened this issue Feb 14, 2024 · 3 comments
Labels
Bug bug should be fixed

Comments

@albertz
Copy link
Contributor

albertz commented Feb 14, 2024

Currently you pin to an old typeguard version. This is a problem for me, because I want to use it together with some other code which requires a newer typeguard version.

As I understand #5009, just no-one so far has invested some effort in updating the code? But in principle, you are ok with updating the code?

As I understand it, instead of using check_argument_types() and check_return_type(), use the @typechecked decorator on the function.

Note, I also asked whether we can maybe get back check_argument_types() and check_return_type() in newer versions of typeguard, but I doubt that they would add it back. agronholm/typeguard#437

@albertz albertz added the Bug bug should be fixed label Feb 14, 2024
@sw005320
Copy link
Contributor

Thanks, @albertz.

@kamo-naoyuki, can you answer it?

@kamo-naoyuki
Copy link
Collaborator

@albertz Yes. It's great if you'll update.

@sw005320
Copy link
Contributor

sw005320 commented Apr 8, 2024

We can successfully update typeguard

@sw005320 sw005320 closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug bug should be fixed
Projects
None yet
Development

No branches or pull requests

3 participants