Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Deprecating Personal Config #32

Merged
merged 3 commits into from Sep 23, 2019

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Jul 15, 2019

@mysticatea mysticatea added the Initial Commenting This RFC is in the initial feedback stage label Jul 15, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

I don't think this has to be tied directly to this RFC, but if we're going to officially take the stance that ESLint should be used locally, I do think it's worth revisiting the topic brought up here. I know some other projects have split out their CLI code into a separate package altogether (webpack-cli and @babel/cli, for example).

designs/2019-deprecating-personal-config/README.md Outdated Show resolved Hide resolved
@not-an-aardvark
Copy link
Member

I think we should aim to support two main use cases:

  • Local config file, local installation of shareable configs/plugins
  • Config file located somewhere in a different project (loaded using the --config flag), shareable configs/plugins installed relative to that config. Currently this also requires the --resolve-plugins-relative-to flag -- maybe we could make that flag's effect automatic when --config is used.

In other words, whoever maintains top-level ESLint setup should also be in charge of specifying shareable configs/plugins as dependencies. We should encourage users to avoid situations where this is not the case (e.g. external config file with locally-installed plugins) because this can easily lead to problems when a config file or its dependencies need to be updated.

@mysticatea mysticatea added Final Commenting This RFC is in the final week of commenting and removed Initial Commenting This RFC is in the initial feedback stage labels Aug 7, 2019
@mysticatea mysticatea merged commit 34f2f57 into master Sep 23, 2019
@mysticatea mysticatea deleted the 2019-deprecating-personal-config branch September 23, 2019 22:25
@mysticatea mysticatea added the breaking change This RFC contains breaking changes label Oct 14, 2019
mysticatea added a commit to eslint/eslint that referenced this pull request Oct 14, 2019
kaicataldo pushed a commit to eslint/eslint that referenced this pull request Nov 15, 2019
…#12426)

* Update: deprecate personal config (fixes #11914, refs eslint/rfcs#32)

* Update docs/user-guide/configuring.md

Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>

* update the deprecation note
kodiakhq bot pushed a commit to mcansh/blog that referenced this pull request Nov 26, 2019
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

If you make any changes to it yourself then they will take precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [eslint](https://github.com/eslint/eslint) from 6.6.0 to 6.7.1.
<details>
<summary>Release notes</summary>

*Sourced from [eslint's releases](https://github.com/eslint/eslint/releases).*

> ## v6.7.1
> * [`dd1e9f4`](eslint/eslint@dd1e9f4) Fix: revert changes to key-spacing due to regression ([#12598](https://github-redirect.dependabot.com/eslint/eslint/issues/12598)) (Kai Cataldo)
> * [`c644b54`](eslint/eslint@c644b54) Docs: Update README team and sponsors (ESLint Jenkins)
> 
> ## v6.7.0
> * [`312a88f`](eslint/eslint@312a88f) New: Add grouped-accessor-pairs rule (fixes [#12277](https://github-redirect.dependabot.com/eslint/eslint/issues/12277)) ([#12331](https://github-redirect.dependabot.com/eslint/eslint/issues/12331)) (Milos Djermanovic)
> * [`5c68f5f`](eslint/eslint@5c68f5f) Update: Add 'lexicalBindings' to no-implicit-globals and change messages ([#11996](https://github-redirect.dependabot.com/eslint/eslint/issues/11996)) (Milos Djermanovic)
> * [`6eaad96`](eslint/eslint@6eaad96) New: Add suggestions API ([#12384](https://github-redirect.dependabot.com/eslint/eslint/issues/12384)) (Will Douglas)
> * [`b336fbe`](eslint/eslint@b336fbe) Fix: indent rule with JSX spread props ([#12581](https://github-redirect.dependabot.com/eslint/eslint/issues/12581)) (Nathan Woltman)
> * [`97c745d`](eslint/eslint@97c745d) Update: Report assignment expression location in no-cond-assign ([#12465](https://github-redirect.dependabot.com/eslint/eslint/issues/12465)) (Milos Djermanovic)
> * [`0f01f3d`](eslint/eslint@0f01f3d) Update: Check member expressions with `this` in operator-assignment ([#12495](https://github-redirect.dependabot.com/eslint/eslint/issues/12495)) (Milos Djermanovic)
> * [`62c7038`](eslint/eslint@62c7038) Fix: invalid token checking in computed-property-spacing (fixes [#12198](https://github-redirect.dependabot.com/eslint/eslint/issues/12198)) ([#12533](https://github-redirect.dependabot.com/eslint/eslint/issues/12533)) (YeonJuan)
> * [`4f8a1ee`](eslint/eslint@4f8a1ee) Update: Add enforceForClassMembers option to no-useless-computed-key ([#12110](https://github-redirect.dependabot.com/eslint/eslint/issues/12110)) (ark120202)
> * [`1a2eb99`](eslint/eslint@1a2eb99) New: new rule no-constructor-return (fixes [#12481](https://github-redirect.dependabot.com/eslint/eslint/issues/12481)) ([#12529](https://github-redirect.dependabot.com/eslint/eslint/issues/12529)) (Pig Fang)
> * [`ca3b2a6`](eslint/eslint@ca3b2a6) New: ignorePatterns in config files (refs [eslint/rfcs#22](https://github-redirect.dependabot.com/eslint/rfcs/issues/22)) ([#12274](https://github-redirect.dependabot.com/eslint/eslint/issues/12274)) (Toru Nagashima)
> * [`60204a3`](eslint/eslint@60204a3) Docs: Added another Textmate 2 bundle. ([#12580](https://github-redirect.dependabot.com/eslint/eslint/issues/12580)) (Ryan Fitzer)
> * [`62623f9`](eslint/eslint@62623f9) Fix: preserve whitespace in multiline-comment-style (fixes [#12312](https://github-redirect.dependabot.com/eslint/eslint/issues/12312)) ([#12316](https://github-redirect.dependabot.com/eslint/eslint/issues/12316)) (Kai Cataldo)
> * [`17a8849`](eslint/eslint@17a8849) New: Add no-dupe-else-if rule (fixes [#12469](https://github-redirect.dependabot.com/eslint/eslint/issues/12469)) ([#12504](https://github-redirect.dependabot.com/eslint/eslint/issues/12504)) (Milos Djermanovic)
> * [`41a78fd`](eslint/eslint@41a78fd) Update: improve location for semi and comma-dangle ([#12380](https://github-redirect.dependabot.com/eslint/eslint/issues/12380)) (Chiawen Chen)
> * [`0a480f8`](eslint/eslint@0a480f8) Docs: Change "Code Conventions" link in pull-requests.md ([#12401](https://github-redirect.dependabot.com/eslint/eslint/issues/12401)) (Denis Sikuler)
> * [`fed20bb`](eslint/eslint@fed20bb) Fix: require-await crash on global await ([#12571](https://github-redirect.dependabot.com/eslint/eslint/issues/12571)) (Brad Zacher)
> * [`b8030fc`](eslint/eslint@b8030fc) Update: deprecate personal config (fixes [#11914](https://github-redirect.dependabot.com/eslint/eslint/issues/11914), refs [eslint/rfcs#32](https://github-redirect.dependabot.com/eslint/rfcs/issues/32)) ([#12426](https://github-redirect.dependabot.com/eslint/eslint/issues/12426)) (Toru Nagashima)
> * [`40c8c32`](eslint/eslint@40c8c32) Fix: improve report location for object-curly-spacing ([#12563](https://github-redirect.dependabot.com/eslint/eslint/issues/12563)) (Milos Djermanovic)
> * [`1110045`](eslint/eslint@1110045) Fix: ignore marker-only comments in spaced-comment (fixes [#12036](https://github-redirect.dependabot.com/eslint/eslint/issues/12036)) ([#12558](https://github-redirect.dependabot.com/eslint/eslint/issues/12558)) (Milos Djermanovic)
> * [`6503cb8`](eslint/eslint@6503cb8) Update: Fix uglified object align in key-spacing (fixes [#11414](https://github-redirect.dependabot.com/eslint/eslint/issues/11414)) ([#12472](https://github-redirect.dependabot.com/eslint/eslint/issues/12472)) (YeonJuan)
> * [`40791af`](eslint/eslint@40791af) Docs: clarify ignoreDestructuring option in the camelcase rule ([#12553](https://github-redirect.dependabot.com/eslint/eslint/issues/12553)) (Milos Djermanovic)
> * [`07d398d`](eslint/eslint@07d398d) Chore: Add GitHub organization to Sponsor button ([#12562](https://github-redirect.dependabot.com/eslint/eslint/issues/12562)) (Brandon Mills)
> * [`a477707`](eslint/eslint@a477707) Chore: Format style guide links so they can be clicked ([#12189](https://github-redirect.dependabot.com/eslint/eslint/issues/12189)) (Ivan V)
> * [`0f7edef`](eslint/eslint@0f7edef) Update: add react plugin config for eslint init ([#12446](https://github-redirect.dependabot.com/eslint/eslint/issues/12446)) (Ibrahim Rouis)
> * [`448ff1e`](eslint/eslint@448ff1e) Update: Report '\08' and '\09' in no-octal-escape (fixes [#12080](https://github-redirect.dependabot.com/eslint/eslint/issues/12080)) ([#12526](https://github-redirect.dependabot.com/eslint/eslint/issues/12526)) (Milos Djermanovic)
> * [`45aa6a3`](eslint/eslint@45aa6a3) New: Add no-setter-return rule (fixes [#12285](https://github-redirect.dependabot.com/eslint/eslint/issues/12285)) ([#12346](https://github-redirect.dependabot.com/eslint/eslint/issues/12346)) (Milos Djermanovic)
> * [`0afb518`](eslint/eslint@0afb518) Fix: invalid autofix in function-call-argument-newline (fixes [#12454](https://github-redirect.dependabot.com/eslint/eslint/issues/12454)) ([#12539](https://github-redirect.dependabot.com/eslint/eslint/issues/12539)) (YeonJuan)
> * [`90305e0`](eslint/eslint@90305e0) Update: Depcrecate isSpaceBetweenTokens() ([#12519](https://github-redirect.dependabot.com/eslint/eslint/issues/12519)) (Kai Cataldo)
> * [`41b1e43`](eslint/eslint@41b1e43) New: add option for camelcase (fixes [#12527](https://github-redirect.dependabot.com/eslint/eslint/issues/12527)) ([#12528](https://github-redirect.dependabot.com/eslint/eslint/issues/12528)) (Pig Fang)
> * [`f49f1e0`](eslint/eslint@f49f1e0) Upgrade: upgrade optionator to avoid license issue (fixes [#11536](https://github-redirect.dependabot.com/eslint/eslint/issues/11536)) ([#12537](https://github-redirect.dependabot.com/eslint/eslint/issues/12537)) (Pig Fang)
> * [`0286b57`](eslint/eslint@0286b57) Docs: Clean up Getting Started Guide ([#12544](https://github-redirect.dependabot.com/eslint/eslint/issues/12544)) (Nicholas C. Zakas)
> * [`575a98d`](eslint/eslint@575a98d) Chore: Add funding field to package.json ([#12543](https://github-redirect.dependabot.com/eslint/eslint/issues/12543)) (Nicholas C. Zakas)
> * [`9e29e18`](eslint/eslint@9e29e18) Fix: sourceCode#isSpaceBetweenTokens() checks non-adjacent tokens ([#12491](https://github-redirect.dependabot.com/eslint/eslint/issues/12491)) (Kai Cataldo)
> * [`5868550`](eslint/eslint@5868550) Docs: add notice about `function` keyword in keyword-spacing ([#12524](https://github-redirect.dependabot.com/eslint/eslint/issues/12524)) (Pig Fang)
> * [`bb556d5`](eslint/eslint@bb556d5) Fix: curly `multi` reports single lexical declarations (fixes [#11908](https://github-redirect.dependabot.com/eslint/eslint/issues/11908)) ([#12513](https://github-redirect.dependabot.com/eslint/eslint/issues/12513)) (Milos Djermanovic)
> * [`ac60621`](eslint/eslint@ac60621) Fix: unexpected autofix in prefer-const (fixes [#12514](https://github-redirect.dependabot.com/eslint/eslint/issues/12514)) ([#12521](https://github-redirect.dependabot.com/eslint/eslint/issues/12521)) (YeonJuan)
> * [`990065e`](eslint/eslint@990065e) Update: curly multi-or-nest flagging semis on next line (fixes [#12370](https://github-redirect.dependabot.com/eslint/eslint/issues/12370)) ([#12378](https://github-redirect.dependabot.com/eslint/eslint/issues/12378)) (cherryblossom000)
> * [`084a8a6`](eslint/eslint@084a8a6) Fix: no-cond-assign with `always` option reports switch case clauses ([#12470](https://github-redirect.dependabot.com/eslint/eslint/issues/12470)) (Milos Djermanovic)
> * [`7e41355`](eslint/eslint@7e41355) Update: improve report location for space-infix-ops ([#12324](https://github-redirect.dependabot.com/eslint/eslint/issues/12324)) (Chiawen Chen)
> * [`94ff921`](eslint/eslint@94ff921) Update: Add capIsConstructor option to no-invalid-this (fixes [#12271](https://github-redirect.dependabot.com/eslint/eslint/issues/12271)) ([#12308](https://github-redirect.dependabot.com/eslint/eslint/issues/12308)) (Milos Djermanovic)
> * [`de65de6`](eslint/eslint@de65de6) New: Add prefer-exponentiation-operator rule (fixes [#10482](https://github-redirect.dependabot.com/eslint/eslint/issues/10482)) ([#12360](https://github-redirect.dependabot.com/eslint/eslint/issues/12360)) (Milos Djermanovic)
> * [`c78f4a7`](eslint/eslint@c78f4a7) Update: Allow JSX exception in no-inline-comments (fixes [#11270](https://github-redirect.dependabot.com/eslint/eslint/issues/11270)) ([#12388](https://github-redirect.dependabot.com/eslint/eslint/issues/12388)) (Milos Djermanovic)
> * [`e17fb90`](eslint/eslint@e17fb90) New: allowAfterThisConstructor for no-underscore-dangle (fixes [#11488](https://github-redirect.dependabot.com/eslint/eslint/issues/11488)) ([#11489](https://github-redirect.dependabot.com/eslint/eslint/issues/11489)) (sripberger)
> * [`287ca56`](eslint/eslint@287ca56) Build: update CI for Node.js 13 ([#12496](https://github-redirect.dependabot.com/eslint/eslint/issues/12496)) (Toru Nagashima)
> * [`98e1d50`](eslint/eslint@98e1d50) Upgrade: globals to v12.1.0 ([#12296](https://github-redirect.dependabot.com/eslint/eslint/issues/12296)) (Tony Brix)
></tr></table> ... (truncated)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [eslint's changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md).*

> v6.7.1 - November 24, 2019
> 
> * [`dd1e9f4`](eslint/eslint@dd1e9f4) Fix: revert changes to key-spacing due to regression ([#12598](https://github-redirect.dependabot.com/eslint/eslint/issues/12598)) (Kai Cataldo)
> * [`c644b54`](eslint/eslint@c644b54) Docs: Update README team and sponsors (ESLint Jenkins)
> 
> v6.7.0 - November 22, 2019
> 
> * [`312a88f`](eslint/eslint@312a88f) New: Add grouped-accessor-pairs rule (fixes [#12277](https://github-redirect.dependabot.com/eslint/eslint/issues/12277)) ([#12331](https://github-redirect.dependabot.com/eslint/eslint/issues/12331)) (Milos Djermanovic)
> * [`5c68f5f`](eslint/eslint@5c68f5f) Update: Add 'lexicalBindings' to no-implicit-globals and change messages ([#11996](https://github-redirect.dependabot.com/eslint/eslint/issues/11996)) (Milos Djermanovic)
> * [`6eaad96`](eslint/eslint@6eaad96) New: Add suggestions API ([#12384](https://github-redirect.dependabot.com/eslint/eslint/issues/12384)) (Will Douglas)
> * [`b336fbe`](eslint/eslint@b336fbe) Fix: indent rule with JSX spread props ([#12581](https://github-redirect.dependabot.com/eslint/eslint/issues/12581)) (Nathan Woltman)
> * [`97c745d`](eslint/eslint@97c745d) Update: Report assignment expression location in no-cond-assign ([#12465](https://github-redirect.dependabot.com/eslint/eslint/issues/12465)) (Milos Djermanovic)
> * [`0f01f3d`](eslint/eslint@0f01f3d) Update: Check member expressions with `this` in operator-assignment ([#12495](https://github-redirect.dependabot.com/eslint/eslint/issues/12495)) (Milos Djermanovic)
> * [`62c7038`](eslint/eslint@62c7038) Fix: invalid token checking in computed-property-spacing (fixes [#12198](https://github-redirect.dependabot.com/eslint/eslint/issues/12198)) ([#12533](https://github-redirect.dependabot.com/eslint/eslint/issues/12533)) (YeonJuan)
> * [`4f8a1ee`](eslint/eslint@4f8a1ee) Update: Add enforceForClassMembers option to no-useless-computed-key ([#12110](https://github-redirect.dependabot.com/eslint/eslint/issues/12110)) (ark120202)
> * [`1a2eb99`](eslint/eslint@1a2eb99) New: new rule no-constructor-return (fixes [#12481](https://github-redirect.dependabot.com/eslint/eslint/issues/12481)) ([#12529](https://github-redirect.dependabot.com/eslint/eslint/issues/12529)) (Pig Fang)
> * [`ca3b2a6`](eslint/eslint@ca3b2a6) New: ignorePatterns in config files (refs [eslint/rfcs#22](https://github-redirect.dependabot.com/eslint/rfcs/issues/22)) ([#12274](https://github-redirect.dependabot.com/eslint/eslint/issues/12274)) (Toru Nagashima)
> * [`60204a3`](eslint/eslint@60204a3) Docs: Added another Textmate 2 bundle. ([#12580](https://github-redirect.dependabot.com/eslint/eslint/issues/12580)) (Ryan Fitzer)
> * [`62623f9`](eslint/eslint@62623f9) Fix: preserve whitespace in multiline-comment-style (fixes [#12312](https://github-redirect.dependabot.com/eslint/eslint/issues/12312)) ([#12316](https://github-redirect.dependabot.com/eslint/eslint/issues/12316)) (Kai Cataldo)
> * [`17a8849`](eslint/eslint@17a8849) New: Add no-dupe-else-if rule (fixes [#12469](https://github-redirect.dependabot.com/eslint/eslint/issues/12469)) ([#12504](https://github-redirect.dependabot.com/eslint/eslint/issues/12504)) (Milos Djermanovic)
> * [`41a78fd`](eslint/eslint@41a78fd) Update: improve location for semi and comma-dangle ([#12380](https://github-redirect.dependabot.com/eslint/eslint/issues/12380)) (Chiawen Chen)
> * [`0a480f8`](eslint/eslint@0a480f8) Docs: Change "Code Conventions" link in pull-requests.md ([#12401](https://github-redirect.dependabot.com/eslint/eslint/issues/12401)) (Denis Sikuler)
> * [`fed20bb`](eslint/eslint@fed20bb) Fix: require-await crash on global await ([#12571](https://github-redirect.dependabot.com/eslint/eslint/issues/12571)) (Brad Zacher)
> * [`b8030fc`](eslint/eslint@b8030fc) Update: deprecate personal config (fixes [#11914](https://github-redirect.dependabot.com/eslint/eslint/issues/11914), refs [eslint/rfcs#32](https://github-redirect.dependabot.com/eslint/rfcs/issues/32)) ([#12426](https://github-redirect.dependabot.com/eslint/eslint/issues/12426)) (Toru Nagashima)
> * [`40c8c32`](eslint/eslint@40c8c32) Fix: improve report location for object-curly-spacing ([#12563](https://github-redirect.dependabot.com/eslint/eslint/issues/12563)) (Milos Djermanovic)
> * [`1110045`](eslint/eslint@1110045) Fix: ignore marker-only comments in spaced-comment (fixes [#12036](https://github-redirect.dependabot.com/eslint/eslint/issues/12036)) ([#12558](https://github-redirect.dependabot.com/eslint/eslint/issues/12558)) (Milos Djermanovic)
> * [`6503cb8`](eslint/eslint@6503cb8) Update: Fix uglified object align in key-spacing (fixes [#11414](https://github-redirect.dependabot.com/eslint/eslint/issues/11414)) ([#12472](https://github-redirect.dependabot.com/eslint/eslint/issues/12472)) (YeonJuan)
> * [`40791af`](eslint/eslint@40791af) Docs: clarify ignoreDestructuring option in the camelcase rule ([#12553](https://github-redirect.dependabot.com/eslint/eslint/issues/12553)) (Milos Djermanovic)
> * [`07d398d`](eslint/eslint@07d398d) Chore: Add GitHub organization to Sponsor button ([#12562](https://github-redirect.dependabot.com/eslint/eslint/issues/12562)) (Brandon Mills)
> * [`a477707`](eslint/eslint@a477707) Chore: Format style guide links so they can be clicked ([#12189](https://github-redirect.dependabot.com/eslint/eslint/issues/12189)) (Ivan V)
> * [`0f7edef`](eslint/eslint@0f7edef) Update: add react plugin config for eslint init ([#12446](https://github-redirect.dependabot.com/eslint/eslint/issues/12446)) (Ibrahim Rouis)
> * [`448ff1e`](eslint/eslint@448ff1e) Update: Report '\08' and '\09' in no-octal-escape (fixes [#12080](https://github-redirect.dependabot.com/eslint/eslint/issues/12080)) ([#12526](https://github-redirect.dependabot.com/eslint/eslint/issues/12526)) (Milos Djermanovic)
> * [`45aa6a3`](eslint/eslint@45aa6a3) New: Add no-setter-return rule (fixes [#12285](https://github-redirect.dependabot.com/eslint/eslint/issues/12285)) ([#12346](https://github-redirect.dependabot.com/eslint/eslint/issues/12346)) (Milos Djermanovic)
> * [`0afb518`](eslint/eslint@0afb518) Fix: invalid autofix in function-call-argument-newline (fixes [#12454](https://github-redirect.dependabot.com/eslint/eslint/issues/12454)) ([#12539](https://github-redirect.dependabot.com/eslint/eslint/issues/12539)) (YeonJuan)
> * [`90305e0`](eslint/eslint@90305e0) Update: Depcrecate isSpaceBetweenTokens() ([#12519](https://github-redirect.dependabot.com/eslint/eslint/issues/12519)) (Kai Cataldo)
> * [`41b1e43`](eslint/eslint@41b1e43) New: add option for camelcase (fixes [#12527](https://github-redirect.dependabot.com/eslint/eslint/issues/12527)) ([#12528](https://github-redirect.dependabot.com/eslint/eslint/issues/12528)) (Pig Fang)
> * [`f49f1e0`](eslint/eslint@f49f1e0) Upgrade: upgrade optionator to avoid license issue (fixes [#11536](https://github-redirect.dependabot.com/eslint/eslint/issues/11536)) ([#12537](https://github-redirect.dependabot.com/eslint/eslint/issues/12537)) (Pig Fang)
> * [`0286b57`](eslint/eslint@0286b57) Docs: Clean up Getting Started Guide ([#12544](https://github-redirect.dependabot.com/eslint/eslint/issues/12544)) (Nicholas C. Zakas)
> * [`575a98d`](eslint/eslint@575a98d) Chore: Add funding field to package.json ([#12543](https://github-redirect.dependabot.com/eslint/eslint/issues/12543)) (Nicholas C. Zakas)
> * [`9e29e18`](eslint/eslint@9e29e18) Fix: sourceCode#isSpaceBetweenTokens() checks non-adjacent tokens ([#12491](https://github-redirect.dependabot.com/eslint/eslint/issues/12491)) (Kai Cataldo)
> * [`5868550`](eslint/eslint@5868550) Docs: add notice about `function` keyword in keyword-spacing ([#12524](https://github-redirect.dependabot.com/eslint/eslint/issues/12524)) (Pig Fang)
> * [`bb556d5`](eslint/eslint@bb556d5) Fix: curly `multi` reports single lexical declarations (fixes [#11908](https://github-redirect.dependabot.com/eslint/eslint/issues/11908)) ([#12513](https://github-redirect.dependabot.com/eslint/eslint/issues/12513)) (Milos Djermanovic)
> * [`ac60621`](eslint/eslint@ac60621) Fix: unexpected autofix in prefer-const (fixes [#12514](https://github-redirect.dependabot.com/eslint/eslint/issues/12514)) ([#12521](https://github-redirect.dependabot.com/eslint/eslint/issues/12521)) (YeonJuan)
> * [`990065e`](eslint/eslint@990065e) Update: curly multi-or-nest flagging semis on next line (fixes [#12370](https://github-redirect.dependabot.com/eslint/eslint/issues/12370)) ([#12378](https://github-redirect.dependabot.com/eslint/eslint/issues/12378)) (cherryblossom000)
> * [`084a8a6`](eslint/eslint@084a8a6) Fix: no-cond-assign with `always` option reports switch case clauses ([#12470](https://github-redirect.dependabot.com/eslint/eslint/issues/12470)) (Milos Djermanovic)
> * [`7e41355`](eslint/eslint@7e41355) Update: improve report location for space-infix-ops ([#12324](https://github-redirect.dependabot.com/eslint/eslint/issues/12324)) (Chiawen Chen)
> * [`94ff921`](eslint/eslint@94ff921) Update: Add capIsConstructor option to no-invalid-this (fixes [#12271](https://github-redirect.dependabot.com/eslint/eslint/issues/12271)) ([#12308](https://github-redirect.dependabot.com/eslint/eslint/issues/12308)) (Milos Djermanovic)
> * [`de65de6`](eslint/eslint@de65de6) New: Add prefer-exponentiation-operator rule (fixes [#10482](https://github-redirect.dependabot.com/eslint/eslint/issues/10482)) ([#12360](https://github-redirect.dependabot.com/eslint/eslint/issues/12360)) (Milos Djermanovic)
> * [`c78f4a7`](eslint/eslint@c78f4a7) Update: Allow JSX exception in no-inline-comments (fixes [#11270](https://github-redirect.dependabot.com/eslint/eslint/issues/11270)) ([#12388](https://github-redirect.dependabot.com/eslint/eslint/issues/12388)) (Milos Djermanovic)
> * [`e17fb90`](eslint/eslint@e17fb90) New: allowAfterThisConstructor for no-underscore-dangle (fixes [#11488](https://github-redirect.dependabot.com/eslint/eslint/issues/11488)) ([#11489](https://github-redirect.dependabot.com/eslint/eslint/issues/11489)) (sripberger)
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`af95154`](eslint/eslint@af95154) 6.7.1
- [`9361824`](eslint/eslint@9361824) Build: changelog update for 6.7.1
- [`dd1e9f4`](eslint/eslint@dd1e9f4) Fix: revert changes to key-spacing due to regression ([#12598](https://github-redirect.dependabot.com/eslint/eslint/issues/12598))
- [`c644b54`](eslint/eslint@c644b54) Docs: Update README team and sponsors
- [`61848b4`](eslint/eslint@61848b4) 6.7.0
- [`9162db9`](eslint/eslint@9162db9) Build: changelog update for 6.7.0
- [`312a88f`](eslint/eslint@312a88f) New: Add grouped-accessor-pairs rule (fixes [#12277](https://github-redirect.dependabot.com/eslint/eslint/issues/12277)) ([#12331](https://github-redirect.dependabot.com/eslint/eslint/issues/12331))
- [`5c68f5f`](eslint/eslint@5c68f5f) Update: Add 'lexicalBindings' to no-implicit-globals and change messages ([#11](https://github-redirect.dependabot.com/eslint/eslint/issues/11)...
- [`6eaad96`](eslint/eslint@6eaad96) New: Add suggestions API ([#12384](https://github-redirect.dependabot.com/eslint/eslint/issues/12384))
- [`b336fbe`](eslint/eslint@b336fbe) Fix: indent rule with JSX spread props ([#12581](https://github-redirect.dependabot.com/eslint/eslint/issues/12581))
- Additional commits viewable in [compare view](eslint/eslint@v6.6.0...v6.7.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=6.6.0&new-version=6.7.1)](https://dependabot.com/compatibility-score.html?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=6.6.0&new-version=6.7.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>
kodiakhq bot added a commit to NateRadebaugh/react-datetime that referenced this pull request Dec 6, 2019
Bumps [eslint](https://github.com/eslint/eslint) from 6.6.0 to 6.7.2.
<details>
<summary>Release notes</summary>

*Sourced from [eslint's releases](https://github.com/eslint/eslint/releases).*

> ## v6.7.2
> * [`bc435a9`](eslint/eslint@bc435a9) Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes [#12614](https://github-redirect.dependabot.com/eslint/eslint/issues/12614)) ([#12616](https://github-redirect.dependabot.com/eslint/eslint/issues/12616)) (Toru Nagashima)
> * [`4928d51`](eslint/eslint@4928d51) Fix: don't ignore the entry directory (fixes [#12604](https://github-redirect.dependabot.com/eslint/eslint/issues/12604)) ([#12607](https://github-redirect.dependabot.com/eslint/eslint/issues/12607)) (Toru Nagashima)
> * [`b41677a`](eslint/eslint@b41677a) Docs: Clarify suggestion's data in Working with Rules (refs [#12606](https://github-redirect.dependabot.com/eslint/eslint/issues/12606)) ([#12617](https://github-redirect.dependabot.com/eslint/eslint/issues/12617)) (Milos Djermanovic)
> * [`ea16de4`](eslint/eslint@ea16de4) Fix: Support tagged template literal generics in no-unexpected-multiline ([#11698](https://github-redirect.dependabot.com/eslint/eslint/issues/11698)) (Brad Zacher)
> * [`fa6415d`](eslint/eslint@fa6415d) Sponsors: Sync README with website (ESLint Jenkins)
> * [`e1e158b`](eslint/eslint@e1e158b) Sponsors: Sync README with website (ESLint Jenkins)
> 
> ## v6.7.1
> * [`dd1e9f4`](eslint/eslint@dd1e9f4) Fix: revert changes to key-spacing due to regression ([#12598](https://github-redirect.dependabot.com/eslint/eslint/issues/12598)) (Kai Cataldo)
> * [`c644b54`](eslint/eslint@c644b54) Docs: Update README team and sponsors (ESLint Jenkins)
> 
> ## v6.7.0
> * [`312a88f`](eslint/eslint@312a88f) New: Add grouped-accessor-pairs rule (fixes [#12277](https://github-redirect.dependabot.com/eslint/eslint/issues/12277)) ([#12331](https://github-redirect.dependabot.com/eslint/eslint/issues/12331)) (Milos Djermanovic)
> * [`5c68f5f`](eslint/eslint@5c68f5f) Update: Add 'lexicalBindings' to no-implicit-globals and change messages ([#11996](https://github-redirect.dependabot.com/eslint/eslint/issues/11996)) (Milos Djermanovic)
> * [`6eaad96`](eslint/eslint@6eaad96) New: Add suggestions API ([#12384](https://github-redirect.dependabot.com/eslint/eslint/issues/12384)) (Will Douglas)
> * [`b336fbe`](eslint/eslint@b336fbe) Fix: indent rule with JSX spread props ([#12581](https://github-redirect.dependabot.com/eslint/eslint/issues/12581)) (Nathan Woltman)
> * [`97c745d`](eslint/eslint@97c745d) Update: Report assignment expression location in no-cond-assign ([#12465](https://github-redirect.dependabot.com/eslint/eslint/issues/12465)) (Milos Djermanovic)
> * [`0f01f3d`](eslint/eslint@0f01f3d) Update: Check member expressions with `this` in operator-assignment ([#12495](https://github-redirect.dependabot.com/eslint/eslint/issues/12495)) (Milos Djermanovic)
> * [`62c7038`](eslint/eslint@62c7038) Fix: invalid token checking in computed-property-spacing (fixes [#12198](https://github-redirect.dependabot.com/eslint/eslint/issues/12198)) ([#12533](https://github-redirect.dependabot.com/eslint/eslint/issues/12533)) (YeonJuan)
> * [`4f8a1ee`](eslint/eslint@4f8a1ee) Update: Add enforceForClassMembers option to no-useless-computed-key ([#12110](https://github-redirect.dependabot.com/eslint/eslint/issues/12110)) (ark120202)
> * [`1a2eb99`](eslint/eslint@1a2eb99) New: new rule no-constructor-return (fixes [#12481](https://github-redirect.dependabot.com/eslint/eslint/issues/12481)) ([#12529](https://github-redirect.dependabot.com/eslint/eslint/issues/12529)) (Pig Fang)
> * [`ca3b2a6`](eslint/eslint@ca3b2a6) New: ignorePatterns in config files (refs [eslint/rfcs#22](https://github-redirect.dependabot.com/eslint/rfcs/issues/22)) ([#12274](https://github-redirect.dependabot.com/eslint/eslint/issues/12274)) (Toru Nagashima)
> * [`60204a3`](eslint/eslint@60204a3) Docs: Added another Textmate 2 bundle. ([#12580](https://github-redirect.dependabot.com/eslint/eslint/issues/12580)) (Ryan Fitzer)
> * [`62623f9`](eslint/eslint@62623f9) Fix: preserve whitespace in multiline-comment-style (fixes [#12312](https://github-redirect.dependabot.com/eslint/eslint/issues/12312)) ([#12316](https://github-redirect.dependabot.com/eslint/eslint/issues/12316)) (Kai Cataldo)
> * [`17a8849`](eslint/eslint@17a8849) New: Add no-dupe-else-if rule (fixes [#12469](https://github-redirect.dependabot.com/eslint/eslint/issues/12469)) ([#12504](https://github-redirect.dependabot.com/eslint/eslint/issues/12504)) (Milos Djermanovic)
> * [`41a78fd`](eslint/eslint@41a78fd) Update: improve location for semi and comma-dangle ([#12380](https://github-redirect.dependabot.com/eslint/eslint/issues/12380)) (Chiawen Chen)
> * [`0a480f8`](eslint/eslint@0a480f8) Docs: Change "Code Conventions" link in pull-requests.md ([#12401](https://github-redirect.dependabot.com/eslint/eslint/issues/12401)) (Denis Sikuler)
> * [`fed20bb`](eslint/eslint@fed20bb) Fix: require-await crash on global await ([#12571](https://github-redirect.dependabot.com/eslint/eslint/issues/12571)) (Brad Zacher)
> * [`b8030fc`](eslint/eslint@b8030fc) Update: deprecate personal config (fixes [#11914](https://github-redirect.dependabot.com/eslint/eslint/issues/11914), refs [eslint/rfcs#32](https://github-redirect.dependabot.com/eslint/rfcs/issues/32)) ([#12426](https://github-redirect.dependabot.com/eslint/eslint/issues/12426)) (Toru Nagashima)
> * [`40c8c32`](eslint/eslint@40c8c32) Fix: improve report location for object-curly-spacing ([#12563](https://github-redirect.dependabot.com/eslint/eslint/issues/12563)) (Milos Djermanovic)
> * [`1110045`](eslint/eslint@1110045) Fix: ignore marker-only comments in spaced-comment (fixes [#12036](https://github-redirect.dependabot.com/eslint/eslint/issues/12036)) ([#12558](https://github-redirect.dependabot.com/eslint/eslint/issues/12558)) (Milos Djermanovic)
> * [`6503cb8`](eslint/eslint@6503cb8) Update: Fix uglified object align in key-spacing (fixes [#11414](https://github-redirect.dependabot.com/eslint/eslint/issues/11414)) ([#12472](https://github-redirect.dependabot.com/eslint/eslint/issues/12472)) (YeonJuan)
> * [`40791af`](eslint/eslint@40791af) Docs: clarify ignoreDestructuring option in the camelcase rule ([#12553](https://github-redirect.dependabot.com/eslint/eslint/issues/12553)) (Milos Djermanovic)
> * [`07d398d`](eslint/eslint@07d398d) Chore: Add GitHub organization to Sponsor button ([#12562](https://github-redirect.dependabot.com/eslint/eslint/issues/12562)) (Brandon Mills)
> * [`a477707`](eslint/eslint@a477707) Chore: Format style guide links so they can be clicked ([#12189](https://github-redirect.dependabot.com/eslint/eslint/issues/12189)) (Ivan V)
> * [`0f7edef`](eslint/eslint@0f7edef) Update: add react plugin config for eslint init ([#12446](https://github-redirect.dependabot.com/eslint/eslint/issues/12446)) (Ibrahim Rouis)
> * [`448ff1e`](eslint/eslint@448ff1e) Update: Report '\08' and '\09' in no-octal-escape (fixes [#12080](https://github-redirect.dependabot.com/eslint/eslint/issues/12080)) ([#12526](https://github-redirect.dependabot.com/eslint/eslint/issues/12526)) (Milos Djermanovic)
> * [`45aa6a3`](eslint/eslint@45aa6a3) New: Add no-setter-return rule (fixes [#12285](https://github-redirect.dependabot.com/eslint/eslint/issues/12285)) ([#12346](https://github-redirect.dependabot.com/eslint/eslint/issues/12346)) (Milos Djermanovic)
> * [`0afb518`](eslint/eslint@0afb518) Fix: invalid autofix in function-call-argument-newline (fixes [#12454](https://github-redirect.dependabot.com/eslint/eslint/issues/12454)) ([#12539](https://github-redirect.dependabot.com/eslint/eslint/issues/12539)) (YeonJuan)
> * [`90305e0`](eslint/eslint@90305e0) Update: Depcrecate isSpaceBetweenTokens() ([#12519](https://github-redirect.dependabot.com/eslint/eslint/issues/12519)) (Kai Cataldo)
> * [`41b1e43`](eslint/eslint@41b1e43) New: add option for camelcase (fixes [#12527](https://github-redirect.dependabot.com/eslint/eslint/issues/12527)) ([#12528](https://github-redirect.dependabot.com/eslint/eslint/issues/12528)) (Pig Fang)
> * [`f49f1e0`](eslint/eslint@f49f1e0) Upgrade: upgrade optionator to avoid license issue (fixes [#11536](https://github-redirect.dependabot.com/eslint/eslint/issues/11536)) ([#12537](https://github-redirect.dependabot.com/eslint/eslint/issues/12537)) (Pig Fang)
> * [`0286b57`](eslint/eslint@0286b57) Docs: Clean up Getting Started Guide ([#12544](https://github-redirect.dependabot.com/eslint/eslint/issues/12544)) (Nicholas C. Zakas)
> * [`575a98d`](eslint/eslint@575a98d) Chore: Add funding field to package.json ([#12543](https://github-redirect.dependabot.com/eslint/eslint/issues/12543)) (Nicholas C. Zakas)
> * [`9e29e18`](eslint/eslint@9e29e18) Fix: sourceCode#isSpaceBetweenTokens() checks non-adjacent tokens ([#12491](https://github-redirect.dependabot.com/eslint/eslint/issues/12491)) (Kai Cataldo)
> * [`5868550`](eslint/eslint@5868550) Docs: add notice about `function` keyword in keyword-spacing ([#12524](https://github-redirect.dependabot.com/eslint/eslint/issues/12524)) (Pig Fang)
> * [`bb556d5`](eslint/eslint@bb556d5) Fix: curly `multi` reports single lexical declarations (fixes [#11908](https://github-redirect.dependabot.com/eslint/eslint/issues/11908)) ([#12513](https://github-redirect.dependabot.com/eslint/eslint/issues/12513)) (Milos Djermanovic)
> * [`ac60621`](eslint/eslint@ac60621) Fix: unexpected autofix in prefer-const (fixes [#12514](https://github-redirect.dependabot.com/eslint/eslint/issues/12514)) ([#12521](https://github-redirect.dependabot.com/eslint/eslint/issues/12521)) (YeonJuan)
> * [`990065e`](eslint/eslint@990065e) Update: curly multi-or-nest flagging semis on next line (fixes [#12370](https://github-redirect.dependabot.com/eslint/eslint/issues/12370)) ([#12378](https://github-redirect.dependabot.com/eslint/eslint/issues/12378)) (cherryblossom000)
></tr></table> ... (truncated)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [eslint's changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md).*

> v6.7.2 - November 30, 2019
> 
> * [`bc435a9`](eslint/eslint@bc435a9) Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes [#12614](https://github-redirect.dependabot.com/eslint/eslint/issues/12614)) ([#12616](https://github-redirect.dependabot.com/eslint/eslint/issues/12616)) (Toru Nagashima)
> * [`4928d51`](eslint/eslint@4928d51) Fix: don't ignore the entry directory (fixes [#12604](https://github-redirect.dependabot.com/eslint/eslint/issues/12604)) ([#12607](https://github-redirect.dependabot.com/eslint/eslint/issues/12607)) (Toru Nagashima)
> * [`b41677a`](eslint/eslint@b41677a) Docs: Clarify suggestion's data in Working with Rules (refs [#12606](https://github-redirect.dependabot.com/eslint/eslint/issues/12606)) ([#12617](https://github-redirect.dependabot.com/eslint/eslint/issues/12617)) (Milos Djermanovic)
> * [`ea16de4`](eslint/eslint@ea16de4) Fix: Support tagged template literal generics in no-unexpected-multiline ([#11698](https://github-redirect.dependabot.com/eslint/eslint/issues/11698)) (Brad Zacher)
> * [`fa6415d`](eslint/eslint@fa6415d) Sponsors: Sync README with website (ESLint Jenkins)
> * [`e1e158b`](eslint/eslint@e1e158b) Sponsors: Sync README with website (ESLint Jenkins)
> 
> v6.7.1 - November 24, 2019
> 
> * [`dd1e9f4`](eslint/eslint@dd1e9f4) Fix: revert changes to key-spacing due to regression ([#12598](https://github-redirect.dependabot.com/eslint/eslint/issues/12598)) (Kai Cataldo)
> * [`c644b54`](eslint/eslint@c644b54) Docs: Update README team and sponsors (ESLint Jenkins)
> 
> v6.7.0 - November 22, 2019
> 
> * [`312a88f`](eslint/eslint@312a88f) New: Add grouped-accessor-pairs rule (fixes [#12277](https://github-redirect.dependabot.com/eslint/eslint/issues/12277)) ([#12331](https://github-redirect.dependabot.com/eslint/eslint/issues/12331)) (Milos Djermanovic)
> * [`5c68f5f`](eslint/eslint@5c68f5f) Update: Add 'lexicalBindings' to no-implicit-globals and change messages ([#11996](https://github-redirect.dependabot.com/eslint/eslint/issues/11996)) (Milos Djermanovic)
> * [`6eaad96`](eslint/eslint@6eaad96) New: Add suggestions API ([#12384](https://github-redirect.dependabot.com/eslint/eslint/issues/12384)) (Will Douglas)
> * [`b336fbe`](eslint/eslint@b336fbe) Fix: indent rule with JSX spread props ([#12581](https://github-redirect.dependabot.com/eslint/eslint/issues/12581)) (Nathan Woltman)
> * [`97c745d`](eslint/eslint@97c745d) Update: Report assignment expression location in no-cond-assign ([#12465](https://github-redirect.dependabot.com/eslint/eslint/issues/12465)) (Milos Djermanovic)
> * [`0f01f3d`](eslint/eslint@0f01f3d) Update: Check member expressions with `this` in operator-assignment ([#12495](https://github-redirect.dependabot.com/eslint/eslint/issues/12495)) (Milos Djermanovic)
> * [`62c7038`](eslint/eslint@62c7038) Fix: invalid token checking in computed-property-spacing (fixes [#12198](https://github-redirect.dependabot.com/eslint/eslint/issues/12198)) ([#12533](https://github-redirect.dependabot.com/eslint/eslint/issues/12533)) (YeonJuan)
> * [`4f8a1ee`](eslint/eslint@4f8a1ee) Update: Add enforceForClassMembers option to no-useless-computed-key ([#12110](https://github-redirect.dependabot.com/eslint/eslint/issues/12110)) (ark120202)
> * [`1a2eb99`](eslint/eslint@1a2eb99) New: new rule no-constructor-return (fixes [#12481](https://github-redirect.dependabot.com/eslint/eslint/issues/12481)) ([#12529](https://github-redirect.dependabot.com/eslint/eslint/issues/12529)) (Pig Fang)
> * [`ca3b2a6`](eslint/eslint@ca3b2a6) New: ignorePatterns in config files (refs [eslint/rfcs#22](https://github-redirect.dependabot.com/eslint/rfcs/issues/22)) ([#12274](https://github-redirect.dependabot.com/eslint/eslint/issues/12274)) (Toru Nagashima)
> * [`60204a3`](eslint/eslint@60204a3) Docs: Added another Textmate 2 bundle. ([#12580](https://github-redirect.dependabot.com/eslint/eslint/issues/12580)) (Ryan Fitzer)
> * [`62623f9`](eslint/eslint@62623f9) Fix: preserve whitespace in multiline-comment-style (fixes [#12312](https://github-redirect.dependabot.com/eslint/eslint/issues/12312)) ([#12316](https://github-redirect.dependabot.com/eslint/eslint/issues/12316)) (Kai Cataldo)
> * [`17a8849`](eslint/eslint@17a8849) New: Add no-dupe-else-if rule (fixes [#12469](https://github-redirect.dependabot.com/eslint/eslint/issues/12469)) ([#12504](https://github-redirect.dependabot.com/eslint/eslint/issues/12504)) (Milos Djermanovic)
> * [`41a78fd`](eslint/eslint@41a78fd) Update: improve location for semi and comma-dangle ([#12380](https://github-redirect.dependabot.com/eslint/eslint/issues/12380)) (Chiawen Chen)
> * [`0a480f8`](eslint/eslint@0a480f8) Docs: Change "Code Conventions" link in pull-requests.md ([#12401](https://github-redirect.dependabot.com/eslint/eslint/issues/12401)) (Denis Sikuler)
> * [`fed20bb`](eslint/eslint@fed20bb) Fix: require-await crash on global await ([#12571](https://github-redirect.dependabot.com/eslint/eslint/issues/12571)) (Brad Zacher)
> * [`b8030fc`](eslint/eslint@b8030fc) Update: deprecate personal config (fixes [#11914](https://github-redirect.dependabot.com/eslint/eslint/issues/11914), refs [eslint/rfcs#32](https://github-redirect.dependabot.com/eslint/rfcs/issues/32)) ([#12426](https://github-redirect.dependabot.com/eslint/eslint/issues/12426)) (Toru Nagashima)
> * [`40c8c32`](eslint/eslint@40c8c32) Fix: improve report location for object-curly-spacing ([#12563](https://github-redirect.dependabot.com/eslint/eslint/issues/12563)) (Milos Djermanovic)
> * [`1110045`](eslint/eslint@1110045) Fix: ignore marker-only comments in spaced-comment (fixes [#12036](https://github-redirect.dependabot.com/eslint/eslint/issues/12036)) ([#12558](https://github-redirect.dependabot.com/eslint/eslint/issues/12558)) (Milos Djermanovic)
> * [`6503cb8`](eslint/eslint@6503cb8) Update: Fix uglified object align in key-spacing (fixes [#11414](https://github-redirect.dependabot.com/eslint/eslint/issues/11414)) ([#12472](https://github-redirect.dependabot.com/eslint/eslint/issues/12472)) (YeonJuan)
> * [`40791af`](eslint/eslint@40791af) Docs: clarify ignoreDestructuring option in the camelcase rule ([#12553](https://github-redirect.dependabot.com/eslint/eslint/issues/12553)) (Milos Djermanovic)
> * [`07d398d`](eslint/eslint@07d398d) Chore: Add GitHub organization to Sponsor button ([#12562](https://github-redirect.dependabot.com/eslint/eslint/issues/12562)) (Brandon Mills)
> * [`a477707`](eslint/eslint@a477707) Chore: Format style guide links so they can be clicked ([#12189](https://github-redirect.dependabot.com/eslint/eslint/issues/12189)) (Ivan V)
> * [`0f7edef`](eslint/eslint@0f7edef) Update: add react plugin config for eslint init ([#12446](https://github-redirect.dependabot.com/eslint/eslint/issues/12446)) (Ibrahim Rouis)
> * [`448ff1e`](eslint/eslint@448ff1e) Update: Report '\08' and '\09' in no-octal-escape (fixes [#12080](https://github-redirect.dependabot.com/eslint/eslint/issues/12080)) ([#12526](https://github-redirect.dependabot.com/eslint/eslint/issues/12526)) (Milos Djermanovic)
> * [`45aa6a3`](eslint/eslint@45aa6a3) New: Add no-setter-return rule (fixes [#12285](https://github-redirect.dependabot.com/eslint/eslint/issues/12285)) ([#12346](https://github-redirect.dependabot.com/eslint/eslint/issues/12346)) (Milos Djermanovic)
> * [`0afb518`](eslint/eslint@0afb518) Fix: invalid autofix in function-call-argument-newline (fixes [#12454](https://github-redirect.dependabot.com/eslint/eslint/issues/12454)) ([#12539](https://github-redirect.dependabot.com/eslint/eslint/issues/12539)) (YeonJuan)
> * [`90305e0`](eslint/eslint@90305e0) Update: Depcrecate isSpaceBetweenTokens() ([#12519](https://github-redirect.dependabot.com/eslint/eslint/issues/12519)) (Kai Cataldo)
> * [`41b1e43`](eslint/eslint@41b1e43) New: add option for camelcase (fixes [#12527](https://github-redirect.dependabot.com/eslint/eslint/issues/12527)) ([#12528](https://github-redirect.dependabot.com/eslint/eslint/issues/12528)) (Pig Fang)
> * [`f49f1e0`](eslint/eslint@f49f1e0) Upgrade: upgrade optionator to avoid license issue (fixes [#11536](https://github-redirect.dependabot.com/eslint/eslint/issues/11536)) ([#12537](https://github-redirect.dependabot.com/eslint/eslint/issues/12537)) (Pig Fang)
> * [`0286b57`](eslint/eslint@0286b57) Docs: Clean up Getting Started Guide ([#12544](https://github-redirect.dependabot.com/eslint/eslint/issues/12544)) (Nicholas C. Zakas)
> * [`575a98d`](eslint/eslint@575a98d) Chore: Add funding field to package.json ([#12543](https://github-redirect.dependabot.com/eslint/eslint/issues/12543)) (Nicholas C. Zakas)
> * [`9e29e18`](eslint/eslint@9e29e18) Fix: sourceCode#isSpaceBetweenTokens() checks non-adjacent tokens ([#12491](https://github-redirect.dependabot.com/eslint/eslint/issues/12491)) (Kai Cataldo)
> * [`5868550`](eslint/eslint@5868550) Docs: add notice about `function` keyword in keyword-spacing ([#12524](https://github-redirect.dependabot.com/eslint/eslint/issues/12524)) (Pig Fang)
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`dbbba83`](eslint/eslint@dbbba83) 6.7.2
- [`bc54d15`](eslint/eslint@bc54d15) Build: changelog update for 6.7.2
- [`bc435a9`](eslint/eslint@bc435a9) Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes [#12614](https://github-redirect.dependabot.com/eslint/eslint/issues/12614)) ([#12616](https://github-redirect.dependabot.com/eslint/eslint/issues/12616))
- [`4928d51`](eslint/eslint@4928d51) Fix: don't ignore the entry directory (fixes [#12604](https://github-redirect.dependabot.com/eslint/eslint/issues/12604)) ([#12607](https://github-redirect.dependabot.com/eslint/eslint/issues/12607))
- [`b41677a`](eslint/eslint@b41677a) Docs: Clarify suggestion's data in Working with Rules (refs [#12606](https://github-redirect.dependabot.com/eslint/eslint/issues/12606)) ([#12617](https://github-redirect.dependabot.com/eslint/eslint/issues/12617))
- [`ea16de4`](eslint/eslint@ea16de4) Fix: Support tagged template literal generics in no-unexpected-multiline ([#11](https://github-redirect.dependabot.com/eslint/eslint/issues/11)...
- [`fa6415d`](eslint/eslint@fa6415d) Sponsors: Sync README with website
- [`e1e158b`](eslint/eslint@e1e158b) Sponsors: Sync README with website
- [`af95154`](eslint/eslint@af95154) 6.7.1
- [`9361824`](eslint/eslint@9361824) Build: changelog update for 6.7.1
- Additional commits viewable in [compare view](eslint/eslint@v6.6.0...v6.7.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=6.6.0&new-version=6.7.2)](https://dependabot.com/compatibility-score.html?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=6.6.0&new-version=6.7.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>
mysticatea added a commit to eslint/eslint that referenced this pull request Dec 17, 2019
mysticatea added a commit to eslint/eslint that referenced this pull request Jan 7, 2020
@MikeTaylor
Copy link

This RFC is a great reason to stay on ESLint v7.x.

@nbcarey
Copy link

nbcarey commented May 19, 2021

This RFC is a great reason to stay on ESLint v7.x.

Or move to a different linter.

@MikeTaylor
Copy link

Or move to a different linter.

Oh, interesting — do you have thoughts on any alternatives? I'd had the impression that ESLint was one of that "category killers" that sucked up enough air that it was impossible for any alternative to gain traction. But its opinionatedness in this and related areas does not sit well with me, so I am open to alternatives.

@nbcarey
Copy link

nbcarey commented May 19, 2021

Or move to a different linter.

Oh, interesting — do you have thoughts on any alternatives? I'd had the impression that ESLint was one of that "category killers" that sucked up enough air that it was impossible for any alternative to gain traction. But its opinionatedness in this and related areas does not sit well with me, so I am open to alternatives.

Just offhand, there are

  • deno_lint, from Ryan Dahl, the creator of Node.js, who created deno, a more secure alternative to Node.js that addresses some issues/shortcomings/defects that he sees in Node. deno_lint is deno's linter.

  • JSHint — a less-opinionated fork of D. Crockford's overly opinionated JSLint

  • Prettier — rather more opinionated than I like

  • RSLint — newish, but looks interesting

  • Google's Closure Compiler also support linting Javascript.

@MikeTaylor
Copy link

@nbcarey Thank you, really interesting list!

@ljharb
Copy link
Sponsor

ljharb commented May 21, 2021

“more secure” is massively debatable, ftr; and prettier is a small subset of what a linter does.

Projects should be linted, and everyone on a project should be able to use the same linter and config (including “you in the future, perhaps on another machine”). A personal config makes it easy to lose track of things in a project context. The reasons to avoid a personal config apply to every linter, and if you want to override this best practice, you can still do it with eslint, it just requires jumping through more hoops.

@MikeTaylor
Copy link

The reasons not to use personal config are not something that the creator of a lint tool can judge on behalf of his or her users.

In my case, I want to use the unix formatter, because it integrates well with Emacs, which is my dev environment. But I don't want to impose that preference on other members of the team, who no doubt use different dev environments. I agree that making personal changes to _what _ a linter checks is bad form; personal changes to how it reports the results is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This RFC contains breaking changes Final Commenting This RFC is in the final week of commenting
Projects
None yet
8 participants