From 31f9b699da171941ede367c2d1ea880f56d4c888 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Thu, 18 Nov 2021 19:58:16 +0900
Subject: [PATCH] feat: support for private-in syntax

---
 package.json                                  |   2 +-
 .../invalid-missing-private.result.js         |   6 +
 .../private-in/invalid-missing-private.src.js |   5 +
 .../invalid-without-class.result.js           |   6 +
 .../private-in/invalid-without-class.src.js   |   3 +
 .../13/private-in/valid-private-in.result.js  | 554 ++++++++++++++++++
 .../13/private-in/valid-private-in.src.js     |   6 +
 7 files changed, 581 insertions(+), 1 deletion(-)
 create mode 100644 tests/fixtures/ecma-version/13/private-in/invalid-missing-private.result.js
 create mode 100644 tests/fixtures/ecma-version/13/private-in/invalid-missing-private.src.js
 create mode 100644 tests/fixtures/ecma-version/13/private-in/invalid-without-class.result.js
 create mode 100644 tests/fixtures/ecma-version/13/private-in/invalid-without-class.src.js
 create mode 100644 tests/fixtures/ecma-version/13/private-in/valid-private-in.result.js
 create mode 100644 tests/fixtures/ecma-version/13/private-in/valid-private-in.src.js

diff --git a/package.json b/package.json
index ccea67ea..a3e832b3 100644
--- a/package.json
+++ b/package.json
@@ -31,7 +31,7 @@
   },
   "license": "BSD-2-Clause",
   "dependencies": {
-    "acorn": "^8.5.0",
+    "acorn": "^8.6.0",
     "acorn-jsx": "^5.3.1",
     "eslint-visitor-keys": "^3.0.0"
   },
diff --git a/tests/fixtures/ecma-version/13/private-in/invalid-missing-private.result.js b/tests/fixtures/ecma-version/13/private-in/invalid-missing-private.result.js
new file mode 100644
index 00000000..8be4d8b6
--- /dev/null
+++ b/tests/fixtures/ecma-version/13/private-in/invalid-missing-private.result.js
@@ -0,0 +1,6 @@
+export default {
+    "index": 39,
+    "lineNumber": 3,
+    "column": 16,
+    "message": "Private field '#b' must be declared in an enclosing class"
+};
\ No newline at end of file
diff --git a/tests/fixtures/ecma-version/13/private-in/invalid-missing-private.src.js b/tests/fixtures/ecma-version/13/private-in/invalid-missing-private.src.js
new file mode 100644
index 00000000..afae6c04
--- /dev/null
+++ b/tests/fixtures/ecma-version/13/private-in/invalid-missing-private.src.js
@@ -0,0 +1,5 @@
+class C {
+    fn(obj) {
+        return #b in  obj
+    }
+}
diff --git a/tests/fixtures/ecma-version/13/private-in/invalid-without-class.result.js b/tests/fixtures/ecma-version/13/private-in/invalid-without-class.result.js
new file mode 100644
index 00000000..cca88d73
--- /dev/null
+++ b/tests/fixtures/ecma-version/13/private-in/invalid-without-class.result.js
@@ -0,0 +1,6 @@
+export default {
+    "index": 27,
+    "lineNumber": 2,
+    "column": 12,
+    "message": "Unexpected token #a"
+};
\ No newline at end of file
diff --git a/tests/fixtures/ecma-version/13/private-in/invalid-without-class.src.js b/tests/fixtures/ecma-version/13/private-in/invalid-without-class.src.js
new file mode 100644
index 00000000..ada3b6b1
--- /dev/null
+++ b/tests/fixtures/ecma-version/13/private-in/invalid-without-class.src.js
@@ -0,0 +1,3 @@
+function a () {
+    return #a in  obj
+}
diff --git a/tests/fixtures/ecma-version/13/private-in/valid-private-in.result.js b/tests/fixtures/ecma-version/13/private-in/valid-private-in.result.js
new file mode 100644
index 00000000..c9e0d104
--- /dev/null
+++ b/tests/fixtures/ecma-version/13/private-in/valid-private-in.result.js
@@ -0,0 +1,554 @@
+export default {
+    "type": "Program",
+    "loc": {
+        "start": {
+            "line": 1,
+            "column": 0
+        },
+        "end": {
+            "line": 6,
+            "column": 1
+        }
+    },
+    "range": [
+        0,
+        64
+    ],
+    "body": [
+        {
+            "type": "ClassDeclaration",
+            "loc": {
+                "start": {
+                    "line": 1,
+                    "column": 0
+                },
+                "end": {
+                    "line": 6,
+                    "column": 1
+                }
+            },
+            "range": [
+                0,
+                64
+            ],
+            "id": {
+                "type": "Identifier",
+                "loc": {
+                    "start": {
+                        "line": 1,
+                        "column": 6
+                    },
+                    "end": {
+                        "line": 1,
+                        "column": 7
+                    }
+                },
+                "range": [
+                    6,
+                    7
+                ],
+                "name": "C"
+            },
+            "superClass": null,
+            "body": {
+                "type": "ClassBody",
+                "loc": {
+                    "start": {
+                        "line": 1,
+                        "column": 8
+                    },
+                    "end": {
+                        "line": 6,
+                        "column": 1
+                    }
+                },
+                "range": [
+                    8,
+                    64
+                ],
+                "body": [
+                    {
+                        "type": "PropertyDefinition",
+                        "loc": {
+                            "start": {
+                                "line": 2,
+                                "column": 4
+                            },
+                            "end": {
+                                "line": 2,
+                                "column": 6
+                            }
+                        },
+                        "range": [
+                            14,
+                            16
+                        ],
+                        "static": false,
+                        "computed": false,
+                        "key": {
+                            "type": "PrivateIdentifier",
+                            "loc": {
+                                "start": {
+                                    "line": 2,
+                                    "column": 4
+                                },
+                                "end": {
+                                    "line": 2,
+                                    "column": 6
+                                }
+                            },
+                            "range": [
+                                14,
+                                16
+                            ],
+                            "name": "a"
+                        },
+                        "value": null
+                    },
+                    {
+                        "type": "MethodDefinition",
+                        "loc": {
+                            "start": {
+                                "line": 3,
+                                "column": 4
+                            },
+                            "end": {
+                                "line": 5,
+                                "column": 5
+                            }
+                        },
+                        "range": [
+                            21,
+                            62
+                        ],
+                        "static": false,
+                        "computed": false,
+                        "key": {
+                            "type": "Identifier",
+                            "loc": {
+                                "start": {
+                                    "line": 3,
+                                    "column": 4
+                                },
+                                "end": {
+                                    "line": 3,
+                                    "column": 6
+                                }
+                            },
+                            "range": [
+                                21,
+                                23
+                            ],
+                            "name": "fn"
+                        },
+                        "kind": "method",
+                        "value": {
+                            "type": "FunctionExpression",
+                            "loc": {
+                                "start": {
+                                    "line": 3,
+                                    "column": 6
+                                },
+                                "end": {
+                                    "line": 5,
+                                    "column": 5
+                                }
+                            },
+                            "range": [
+                                23,
+                                62
+                            ],
+                            "id": null,
+                            "expression": false,
+                            "generator": false,
+                            "async": false,
+                            "params": [
+                                {
+                                    "type": "Identifier",
+                                    "loc": {
+                                        "start": {
+                                            "line": 3,
+                                            "column": 7
+                                        },
+                                        "end": {
+                                            "line": 3,
+                                            "column": 10
+                                        }
+                                    },
+                                    "range": [
+                                        24,
+                                        27
+                                    ],
+                                    "name": "obj"
+                                }
+                            ],
+                            "body": {
+                                "type": "BlockStatement",
+                                "loc": {
+                                    "start": {
+                                        "line": 3,
+                                        "column": 12
+                                    },
+                                    "end": {
+                                        "line": 5,
+                                        "column": 5
+                                    }
+                                },
+                                "range": [
+                                    29,
+                                    62
+                                ],
+                                "body": [
+                                    {
+                                        "type": "ReturnStatement",
+                                        "loc": {
+                                            "start": {
+                                                "line": 4,
+                                                "column": 8
+                                            },
+                                            "end": {
+                                                "line": 4,
+                                                "column": 25
+                                            }
+                                        },
+                                        "range": [
+                                            39,
+                                            56
+                                        ],
+                                        "argument": {
+                                            "type": "BinaryExpression",
+                                            "loc": {
+                                                "start": {
+                                                    "line": 4,
+                                                    "column": 15
+                                                },
+                                                "end": {
+                                                    "line": 4,
+                                                    "column": 25
+                                                }
+                                            },
+                                            "range": [
+                                                46,
+                                                56
+                                            ],
+                                            "left": {
+                                                "type": "PrivateIdentifier",
+                                                "loc": {
+                                                    "start": {
+                                                        "line": 4,
+                                                        "column": 15
+                                                    },
+                                                    "end": {
+                                                        "line": 4,
+                                                        "column": 17
+                                                    }
+                                                },
+                                                "range": [
+                                                    46,
+                                                    48
+                                                ],
+                                                "name": "a"
+                                            },
+                                            "operator": "in",
+                                            "right": {
+                                                "type": "Identifier",
+                                                "loc": {
+                                                    "start": {
+                                                        "line": 4,
+                                                        "column": 22
+                                                    },
+                                                    "end": {
+                                                        "line": 4,
+                                                        "column": 25
+                                                    }
+                                                },
+                                                "range": [
+                                                    53,
+                                                    56
+                                                ],
+                                                "name": "obj"
+                                            }
+                                        }
+                                    }
+                                ]
+                            }
+                        }
+                    }
+                ]
+            }
+        }
+    ],
+    "sourceType": "script",
+    "tokens": [
+        {
+            "type": "Keyword",
+            "value": "class",
+            "loc": {
+                "start": {
+                    "line": 1,
+                    "column": 0
+                },
+                "end": {
+                    "line": 1,
+                    "column": 5
+                }
+            },
+            "range": [
+                0,
+                5
+            ]
+        },
+        {
+            "type": "Identifier",
+            "value": "C",
+            "loc": {
+                "start": {
+                    "line": 1,
+                    "column": 6
+                },
+                "end": {
+                    "line": 1,
+                    "column": 7
+                }
+            },
+            "range": [
+                6,
+                7
+            ]
+        },
+        {
+            "type": "Punctuator",
+            "value": "{",
+            "loc": {
+                "start": {
+                    "line": 1,
+                    "column": 8
+                },
+                "end": {
+                    "line": 1,
+                    "column": 9
+                }
+            },
+            "range": [
+                8,
+                9
+            ]
+        },
+        {
+            "type": "PrivateIdentifier",
+            "value": "a",
+            "loc": {
+                "start": {
+                    "line": 2,
+                    "column": 4
+                },
+                "end": {
+                    "line": 2,
+                    "column": 6
+                }
+            },
+            "range": [
+                14,
+                16
+            ]
+        },
+        {
+            "type": "Identifier",
+            "value": "fn",
+            "loc": {
+                "start": {
+                    "line": 3,
+                    "column": 4
+                },
+                "end": {
+                    "line": 3,
+                    "column": 6
+                }
+            },
+            "range": [
+                21,
+                23
+            ]
+        },
+        {
+            "type": "Punctuator",
+            "value": "(",
+            "loc": {
+                "start": {
+                    "line": 3,
+                    "column": 6
+                },
+                "end": {
+                    "line": 3,
+                    "column": 7
+                }
+            },
+            "range": [
+                23,
+                24
+            ]
+        },
+        {
+            "type": "Identifier",
+            "value": "obj",
+            "loc": {
+                "start": {
+                    "line": 3,
+                    "column": 7
+                },
+                "end": {
+                    "line": 3,
+                    "column": 10
+                }
+            },
+            "range": [
+                24,
+                27
+            ]
+        },
+        {
+            "type": "Punctuator",
+            "value": ")",
+            "loc": {
+                "start": {
+                    "line": 3,
+                    "column": 10
+                },
+                "end": {
+                    "line": 3,
+                    "column": 11
+                }
+            },
+            "range": [
+                27,
+                28
+            ]
+        },
+        {
+            "type": "Punctuator",
+            "value": "{",
+            "loc": {
+                "start": {
+                    "line": 3,
+                    "column": 12
+                },
+                "end": {
+                    "line": 3,
+                    "column": 13
+                }
+            },
+            "range": [
+                29,
+                30
+            ]
+        },
+        {
+            "type": "Keyword",
+            "value": "return",
+            "loc": {
+                "start": {
+                    "line": 4,
+                    "column": 8
+                },
+                "end": {
+                    "line": 4,
+                    "column": 14
+                }
+            },
+            "range": [
+                39,
+                45
+            ]
+        },
+        {
+            "type": "PrivateIdentifier",
+            "value": "a",
+            "loc": {
+                "start": {
+                    "line": 4,
+                    "column": 15
+                },
+                "end": {
+                    "line": 4,
+                    "column": 17
+                }
+            },
+            "range": [
+                46,
+                48
+            ]
+        },
+        {
+            "type": "Keyword",
+            "value": "in",
+            "loc": {
+                "start": {
+                    "line": 4,
+                    "column": 18
+                },
+                "end": {
+                    "line": 4,
+                    "column": 20
+                }
+            },
+            "range": [
+                49,
+                51
+            ]
+        },
+        {
+            "type": "Identifier",
+            "value": "obj",
+            "loc": {
+                "start": {
+                    "line": 4,
+                    "column": 22
+                },
+                "end": {
+                    "line": 4,
+                    "column": 25
+                }
+            },
+            "range": [
+                53,
+                56
+            ]
+        },
+        {
+            "type": "Punctuator",
+            "value": "}",
+            "loc": {
+                "start": {
+                    "line": 5,
+                    "column": 4
+                },
+                "end": {
+                    "line": 5,
+                    "column": 5
+                }
+            },
+            "range": [
+                61,
+                62
+            ]
+        },
+        {
+            "type": "Punctuator",
+            "value": "}",
+            "loc": {
+                "start": {
+                    "line": 6,
+                    "column": 0
+                },
+                "end": {
+                    "line": 6,
+                    "column": 1
+                }
+            },
+            "range": [
+                63,
+                64
+            ]
+        }
+    ]
+};
\ No newline at end of file
diff --git a/tests/fixtures/ecma-version/13/private-in/valid-private-in.src.js b/tests/fixtures/ecma-version/13/private-in/valid-private-in.src.js
new file mode 100644
index 00000000..52b850d0
--- /dev/null
+++ b/tests/fixtures/ecma-version/13/private-in/valid-private-in.src.js
@@ -0,0 +1,6 @@
+class C {
+    #a
+    fn(obj) {
+        return #a in  obj
+    }
+}