Chore: add class static blocks tests #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
class-static-blocks
branch
from
6f26ebc
to
657fd74
Compare
aladdin-add
force-pushed
the
class-static-blocks
branch
3 times, most recently
from
7f1e182
to
ce7f636
Compare
aladdin-add
force-pushed
the
class-static-blocks
branch
2 times, most recently
from
47b514a
to
cbee2f7
Compare
36 tasks
aladdin-add
commented
Sep 16, 2021
...a-version/13/class-static-blocks/expressions-arrow-function-static-init-await-binding.src.js
Outdated
Show resolved
Hide resolved
aladdin-add
force-pushed
the
class-static-blocks
branch
from
cbee2f7
to
3fad0e2
Compare
|
It looks like all of the tests generate error objects. I'm guessing that's not what you intended? |
|
it might be the non-error tests diff was not displayed by default. 😄
|
|
Ah ok. I don’t think we need so many tests that result in errors. We don’t need all of the test-262 cases because we are just wrapping what Acorn does. For other new features we’ve just done a handful of tests. |
aladdin-add
force-pushed
the
class-static-blocks
branch
5 times, most recently
from
c62691c
to
33bea67
Compare
aladdin-add
force-pushed
the
class-static-blocks
branch
from
33bea67
to
25bc8b4
Compare
|
just removed some invalid tests. |
nzakas
reviewed
Sep 28, 2021
aladdin-add
force-pushed
the
class-static-blocks
branch
from
25bc8b4
to
c6a8a6b
Compare
aladdin-add
force-pushed
the
class-static-blocks
branch
2 times, most recently
from
cf37983
to
2d7c0ad
Compare
acorn has been upgraded in ee1d3ec, this commit simply added some tests. The tests were copied from test262, refs: tc39/test262@afe217b
aladdin-add
force-pushed
the
class-static-blocks
branch
from
2d7c0ad
to
904094c
Compare
some of these were thrown in "script" mode, should be resolved now. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acorn has been upgraded in ee1d3ec, this commit simply added some tests. The tests were copied from test262, refs: tc39/test262@afe217b