Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove obsolete lib/visitor-keys.js #509

Merged
merged 1 commit into from Jul 9, 2021
Merged

Chore: Remove obsolete lib/visitor-keys.js #509

merged 1 commit into from Jul 9, 2021

Conversation

matz3
Copy link
Contributor

@matz3 matz3 commented Jul 9, 2021

PR #389 deleted "lib/visitor-keys.js" and replaced all usages with the
eslint-visitor-keys package.
PR #387 added lib/visitor-keys.js back again for no apparent reason.

It looks like #387 has been started before #389, so it needed to
integrate those changes and by mistake the file has been added again.

@matz3
Chore: Remove obsolete lib/visitor-keys.js
acb0bce 
PR eslint#389 deleted "lib/visitor-keys.js" and replaced all usages with the
eslint-visitor-keys package.
PR eslint#387 added lib/visitor-keys.js back again for no apparent reason.

It looks like eslint#387 has been started before eslint#389, so it needed to
integrate those changes and by mistake the file has been added again.
aladdin-add
aladdin-add approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks! LGTM, but I'd like one more reviewer.

@aladdin-add
Copy link
Member

can you sign our cla, so we can merge it?

@matz3
Copy link
Contributor Author

matz3 commented Jul 9, 2021

Signed 👍🏻

snitin315
snitin315 approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdjermanovic
mdjermanovic approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

That module is definitely unused now. Also, its content is old.

Since we have the exports field in package.json it can't be accessed, so it feels safe to remove the file.

@aladdin-add aladdin-add merged commit bf57077 into eslint:main Jul 9, 2021
@matz3 matz3 deleted the remove-obsolete-visitor-keys branch July 9, 2021 14:45
@matz3
Copy link
Contributor Author

matz3 commented Jul 9, 2021

Thanks!
Yeah we also got confused by the different content, which is why I tried to understand why the file still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matz3 @aladdin-add @mdjermanovic @snitin315