From a41b60d537d9c35a4b179792a1b081bed04410cb Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Mon, 3 Jan 2022 18:20:31 +0530 Subject: [PATCH 1/4] chore: switch `new syntax` issue template to forms --- .github/ISSUE_TEMPLATE/NEW_SYNTAX.md | 45 ---------------------- .github/ISSUE_TEMPLATE/new-syntax.yml | 54 +++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 45 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/NEW_SYNTAX.md create mode 100644 .github/ISSUE_TEMPLATE/new-syntax.yml diff --git a/.github/ISSUE_TEMPLATE/NEW_SYNTAX.md b/.github/ISSUE_TEMPLATE/NEW_SYNTAX.md deleted file mode 100644 index f3ac551f6ba..00000000000 --- a/.github/ISSUE_TEMPLATE/NEW_SYNTAX.md +++ /dev/null @@ -1,45 +0,0 @@ ---- -name: "\U0001F4DD Request new syntax support" -about: Request new stage 4 syntax be supported. -title: '' -labels: - - core - - new syntax -assignees: '' - ---- - - - -**What is the name of the syntax to implement?** - - - -**Please provide the TC39 URL for the syntax proposal:** - - - -**Please provide some example code for the new syntax:** - -```js -// example code here -``` - -## Implementation Checklist - -Please check off all items that have already been completed. Be sure to paste the pull request URLs next to each item so we can verify the work as done. - -- [ ] Ecma262 update: -- [ ] ESTree update: -- [ ] Acorn update: -- [ ] `eslint-visitor-keys` update: -- [ ] `espree` update: -- [ ] `eslint-scope` update: -- [ ] `eslint` update: - -**Are you willing to submit a pull request to implement this syntax?** - - diff --git a/.github/ISSUE_TEMPLATE/new-syntax.yml b/.github/ISSUE_TEMPLATE/new-syntax.yml new file mode 100644 index 00000000000..8d0b22becd0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/new-syntax.yml @@ -0,0 +1,54 @@ +name: "\U0001F4DD Request new syntax support" +description: "Request new stage 4 syntax be supported." +labels: + - core + - new syntax +body: +- type: markdown + attributes: + value: By opening an issue, you agree to abide by the [Open JS Foundation Code of Conduct](https://eslint.org/conduct). +- type: input + attributes: + label: Syntax name + description: What is the name of the syntax to implement? + placeholder: e.g. "class fields" + validations: + required: true +- type: textarea + attributes: + label: Syntax proposal URL + description: Please provide the TC39 URL for the syntax proposal. + placeholder: e.g. https://github.com/tc39/proposal-top-level-await + validations: + required: true +- type: textarea + attributes: + label: Example code + description: Please provide some example code for the new syntax. + render: js + validations: + required: true +- type: textarea + attributes: + label: Implementation Checklist + description: | + Please check off all items that have already been completed. Be sure to paste the pull request URLs next to each item so we can verify the work as done. + render: markdown + value: | + - [ ] Ecma262 update: + - [ ] ESTree update: + - [ ] Acorn update: + - [ ] `eslint-visitor-keys` update: + - [ ] `espree` update: + - [ ] `eslint-scope` update: + - [ ] `eslint` update: +- type: checkboxes + attributes: + label: Participation + options: + - label: I am willing to submit a pull request for this change. + required: false +- type: textarea + attributes: + label: Additional comments + description: Is there anything else that's important for the team to know? From 695f8778a06d4512d7800bda27d2c71988685503 Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Mon, 3 Jan 2022 19:22:51 +0530 Subject: [PATCH 2/4] chore: fix template --- .github/ISSUE_TEMPLATE/new-syntax.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/new-syntax.yml b/.github/ISSUE_TEMPLATE/new-syntax.yml index 8d0b22becd0..c246e1e17a9 100644 --- a/.github/ISSUE_TEMPLATE/new-syntax.yml +++ b/.github/ISSUE_TEMPLATE/new-syntax.yml @@ -1,4 +1,4 @@ -name: "\U0001F4DD Request new syntax support" +name: "\U0001F4DD Request for new syntax support" description: "Request new stage 4 syntax be supported." labels: - core From 6d734d86583ef8d91f25c0125853d67604ad3875 Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Tue, 4 Jan 2022 15:12:29 +0530 Subject: [PATCH 3/4] chore: use checkboxes --- .github/ISSUE_TEMPLATE/new-syntax.yml | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/new-syntax.yml b/.github/ISSUE_TEMPLATE/new-syntax.yml index c246e1e17a9..94eb65a8e3d 100644 --- a/.github/ISSUE_TEMPLATE/new-syntax.yml +++ b/.github/ISSUE_TEMPLATE/new-syntax.yml @@ -28,20 +28,26 @@ body: render: js validations: required: true -- type: textarea +- type: checkboxes attributes: label: Implementation Checklist description: | Please check off all items that have already been completed. Be sure to paste the pull request URLs next to each item so we can verify the work as done. - render: markdown - value: | - - [ ] Ecma262 update: - - [ ] ESTree update: - - [ ] Acorn update: - - [ ] `eslint-visitor-keys` update: - - [ ] `espree` update: - - [ ] `eslint-scope` update: - - [ ] `eslint` update: + options: + - label: "Ecma262 update: " + required: false + - label: "ESTree update: " + required: false + - label: "Acorn update: >" + required: false + - label: "`eslint-visitor-keys` update: " + required: false + - label: "`espree` update: " + required: false + - label: "`eslint-scope` update: " + required: false + - label: "`eslint` update: " + required: false - type: checkboxes attributes: label: Participation From f153c9cbeabb0be317251da13cb2b34595e6286e Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Tue, 4 Jan 2022 15:13:53 +0530 Subject: [PATCH 4/4] chore: fix typo --- .github/ISSUE_TEMPLATE/new-syntax.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/new-syntax.yml b/.github/ISSUE_TEMPLATE/new-syntax.yml index 94eb65a8e3d..467ff0f2b95 100644 --- a/.github/ISSUE_TEMPLATE/new-syntax.yml +++ b/.github/ISSUE_TEMPLATE/new-syntax.yml @@ -38,7 +38,7 @@ body: required: false - label: "ESTree update: " required: false - - label: "Acorn update: >" + - label: "Acorn update: " required: false - label: "`eslint-visitor-keys` update: " required: false