From 46c39a4f7a08ab7261248ee64c8d8b6424e69c69 Mon Sep 17 00:00:00 2001 From: Sebastian Simon <37915283+SebastianSimon@users.noreply.github.com> Date: Sun, 12 Dec 2021 12:48:47 +0100 Subject: [PATCH 1/2] docs: Mention character classes in no-useless-escape --- docs/rules/no-useless-escape.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/rules/no-useless-escape.md b/docs/rules/no-useless-escape.md index 6088c5cb010..ef89ba47871 100644 --- a/docs/rules/no-useless-escape.md +++ b/docs/rules/no-useless-escape.md @@ -26,7 +26,8 @@ Examples of **incorrect** code for this rule: `\#{foo}`; /\!/; /\@/; - +/[\[\]]/; +/[a-z\-]/; ``` Examples of **correct** code for this rule: @@ -46,7 +47,8 @@ Examples of **correct** code for this rule: /\\/g; /\t/g; /\w\$\*\^\./; - +/[[\]]/; +/[a-z-]/; ``` ## When Not To Use It From ddb5d32056b16ccac47f47f3ee8e6b58f2ca6a42 Mon Sep 17 00:00:00 2001 From: Sebastian Simon <37915283+SebastianSimon@users.noreply.github.com> Date: Sat, 18 Dec 2021 12:19:28 +0100 Subject: [PATCH 2/2] Make it clear which of the brackets needs escaping --- docs/rules/no-useless-escape.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/rules/no-useless-escape.md b/docs/rules/no-useless-escape.md index ef89ba47871..1f54b588d9b 100644 --- a/docs/rules/no-useless-escape.md +++ b/docs/rules/no-useless-escape.md @@ -26,7 +26,7 @@ Examples of **incorrect** code for this rule: `\#{foo}`; /\!/; /\@/; -/[\[\]]/; +/[\[]/; /[a-z\-]/; ``` @@ -47,7 +47,8 @@ Examples of **correct** code for this rule: /\\/g; /\t/g; /\w\$\*\^\./; -/[[\]]/; +/[[]/; +/[\]]/; /[a-z-]/; ```