From ab5dba7574ba6c5758274de2cb94c7c598f88033 Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 00:16:10 +1000 Subject: [PATCH 1/7] Docs: Fix link to code conventions --- docs/developer-guide/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer-guide/contributing/pull-requests.md b/docs/developer-guide/contributing/pull-requests.md index a1bc8f6bffc..ef4169e23d0 100644 --- a/docs/developer-guide/contributing/pull-requests.md +++ b/docs/developer-guide/contributing/pull-requests.md @@ -112,7 +112,7 @@ With your code ready to go, this is a good time to double-check your submission * Make separate pull requests for unrelated changes. Large pull requests with multiple unrelated changes may be closed without merging. * All changes must be accompanied by tests, even if the feature you're working on previously had no tests. * All user-facing changes must be accompanied by appropriate documentation. -* Follow the [Code Conventions](../code-conventions.html). +* Follow the [Code Conventions](../code-conventions.md). ### Step 6: Push your changes From 79b1274402b0f6a0431bb2ac9366aec5f3f540c0 Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 00:18:31 +1000 Subject: [PATCH 2/7] Docs: Fix formattting --- docs/rules/no-obj-calls.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rules/no-obj-calls.md b/docs/rules/no-obj-calls.md index cfd5576eae5..7cd5ac4d4fa 100644 --- a/docs/rules/no-obj-calls.md +++ b/docs/rules/no-obj-calls.md @@ -12,7 +12,7 @@ The [ECMAScript 2015 specification](https://www.ecma-international.org/ecma-262/ And the [ECMAScript 2017 specification](https://www.ecma-international.org/ecma-262/8.0/index.html#sec-atomics-object) makes it clear that `Atomics` cannot be invoked: -> The Atomics object does not have a [[Call]] internal method; it is not possible to invoke the Atomics object as a function. +> The Atomics object does not have a `[[Call]]` internal method; it is not possible to invoke the Atomics object as a function. ## Rule Details From 97d1b47b185e70c18f1023035b4cdc71f001ba44 Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 00:19:21 +1000 Subject: [PATCH 3/7] Docs: Fix formatting of example config All other example configs in the docs spaced curly braces in object literals, so this commit updates this for consistency. --- docs/rules/space-infix-ops.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rules/space-infix-ops.md b/docs/rules/space-infix-ops.md index 406e2030cf4..6a00e50edde 100644 --- a/docs/rules/space-infix-ops.md +++ b/docs/rules/space-infix-ops.md @@ -23,7 +23,7 @@ This rule is aimed at ensuring there are spaces around infix operators. This rule accepts a single options argument with the following defaults: ```json -"space-infix-ops": ["error", {"int32Hint": false}] +"space-infix-ops": ["error", { "int32Hint": false }] ``` ### `int32Hint` From 5f08139fa5eb0bca613384a2810ebb8d7b594636 Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 00:22:26 +1000 Subject: [PATCH 4/7] Docs: Fixed grammar --- docs/rules/symbol-description.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rules/symbol-description.md b/docs/rules/symbol-description.md index eb15d94ff47..61be8767ed5 100644 --- a/docs/rules/symbol-description.md +++ b/docs/rules/symbol-description.md @@ -1,6 +1,6 @@ # require symbol description (symbol-description) -The `Symbol` function may have optional description: +The `Symbol` function may have an optional description: ```js var foo = Symbol("some description"); From 5cc1f98b1ec4639e90650a05e83adaccfa544153 Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 01:27:08 +1000 Subject: [PATCH 5/7] Docs: Revert link to code conventions This reverts commit ab5dba7574ba6c5758274de2cb94c7c598f88033. --- docs/developer-guide/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer-guide/contributing/pull-requests.md b/docs/developer-guide/contributing/pull-requests.md index ef4169e23d0..a1bc8f6bffc 100644 --- a/docs/developer-guide/contributing/pull-requests.md +++ b/docs/developer-guide/contributing/pull-requests.md @@ -112,7 +112,7 @@ With your code ready to go, this is a good time to double-check your submission * Make separate pull requests for unrelated changes. Large pull requests with multiple unrelated changes may be closed without merging. * All changes must be accompanied by tests, even if the feature you're working on previously had no tests. * All user-facing changes must be accompanied by appropriate documentation. -* Follow the [Code Conventions](../code-conventions.md). +* Follow the [Code Conventions](../code-conventions.html). ### Step 6: Push your changes From e2a5311affd42e633f3af4643cacf37ab6d8795e Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 01:34:10 +1000 Subject: [PATCH 6/7] Docs: Revert link to code conventions --- docs/developer-guide/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer-guide/contributing/pull-requests.md b/docs/developer-guide/contributing/pull-requests.md index a1bc8f6bffc..ef4169e23d0 100644 --- a/docs/developer-guide/contributing/pull-requests.md +++ b/docs/developer-guide/contributing/pull-requests.md @@ -112,7 +112,7 @@ With your code ready to go, this is a good time to double-check your submission * Make separate pull requests for unrelated changes. Large pull requests with multiple unrelated changes may be closed without merging. * All changes must be accompanied by tests, even if the feature you're working on previously had no tests. * All user-facing changes must be accompanied by appropriate documentation. -* Follow the [Code Conventions](../code-conventions.html). +* Follow the [Code Conventions](../code-conventions.md). ### Step 6: Push your changes From 33c6af57255573f0d18dbcfe26cb57c4543b3708 Mon Sep 17 00:00:00 2001 From: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Date: Sat, 5 Oct 2019 01:35:29 +1000 Subject: [PATCH 7/7] Docs: Revert link to code conventions Sorry for all the commits. --- docs/developer-guide/contributing/pull-requests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer-guide/contributing/pull-requests.md b/docs/developer-guide/contributing/pull-requests.md index ef4169e23d0..a1bc8f6bffc 100644 --- a/docs/developer-guide/contributing/pull-requests.md +++ b/docs/developer-guide/contributing/pull-requests.md @@ -112,7 +112,7 @@ With your code ready to go, this is a good time to double-check your submission * Make separate pull requests for unrelated changes. Large pull requests with multiple unrelated changes may be closed without merging. * All changes must be accompanied by tests, even if the feature you're working on previously had no tests. * All user-facing changes must be accompanied by appropriate documentation. -* Follow the [Code Conventions](../code-conventions.md). +* Follow the [Code Conventions](../code-conventions.html). ### Step 6: Push your changes