Fix: ensure no-await-in-loop reports the correct node (fixes #9992) #9993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
bug
ilyavolodin
approved these changes
Feb 20, 2018
gyandeeps
approved these changes
Feb 20, 2018
kaicataldo
approved these changes
Feb 20, 2018
|
LGTM. Thanks for contributing! |
taneliang
added a commit
to nusmodifications/nusmods
that referenced
this pull request
Feb 25, 2018
Revert f424811 as upstream bug was fixed (see eslint/eslint#9993)
This was referenced Mar 8, 2018
This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#9992)
What changes did you make? (Give an overview)
This fixes a regression in f012b8c where
no-await-in-loopstarted reporting the surrounding loop node rather than theAwaitExpressionnode. As a result, someeslint-disablecomments broke and caused more errors because they were on the wrong line.Is there anything you'd like reviewers to focus on?
Nothing in particular