Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954)

[rachx]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #9954.

What changes did you make? (Give an overview)
Previously, getAllStrings only filter for tokens with type String. The filter should check if the token type is JSXText as well.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

[kaicataldo]

Thanks for contributing to ESLint! This looks good to me, but I do have one question.

This change will make it so that text in between tags will also be ignored. Is this the desired behavior? The issue only mentions props, so I just wanted to double check.

Example:

var foo = <div className="this is a very long string">this is another very long string</div>;

[rachx]

I am not sure if it is desired behavior but I think

var foo = <div className="this is a very long string"> short </div>;

should be ignored but

var foo = <div>this is another very long string</div>;

should not be ignored (since this case is more avoidable and we usually expect strings to be in quotes)

How about an additional check if the token is surrounded by quotes?

[kaicataldo]

Looked into this a little more, and given the description of the option ("ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string), I do think we should limit this change to just checking the strings in JSX attributes. If we ever wanted to also check the JSXText between tags, we could always do that in a future PR.

How about an additional check if the token is surrounded by quotes?

I think we might be able to just check if the JSXText token is a child of a JSXAttribute node. What do you think?

[rachx]

Updated to check if JSXText token is a child of a JSXAttribute node. I think that will be cleaner than checking if the token's value is surrounded by quotes

[ljharb]

I agree with #9985 (comment); a child node is not a string, even tho it's also text.

[kaicataldo]

LGTM. Thanks for contributing to ESLint!

[not-an-aardvark]

Thanks for contributing!