New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: no-mixed-operators - fixes #9962 #9964
Docs: no-mixed-operators - fixes #9962 #9964
Conversation
Thanks @munkychop! Would you mind tweaking your commit message so that it ends with "(fixes #9962)"? (Unfortunately, our commit-message status check is not yet smart enough to detect when an issue is referenced but it doesn't quite meet our preferred format.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I'm leaving a "request changes" to avoid accidental merging before the commit message is fixed (since our commit-message status check is giving a false positive here). Thanks!
Sure thing, I'll update that now |
dfd1e84
to
c827414
Compare
Thanks @munkychop! I'm sorry for being so specific but we like parentheses around the issue reference. So maybe something like "Docs: Clarify no-mixed-operators options (fixes #9962)"? Really appreciate you sticking with this and working with us. Thanks! |
Ah, I see. Sure thing. |
c827414
to
a7f747f
Compare
Thanks @munkychop, this looks great! I'm going to just let this sit for a few hours in case any other team members want to look, but we'll probably merge this pretty soon. Thanks for contributing and fixing our docs, we really appreciate it. |
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Improved documentation for
no-mixed-operators
rule -allowSamePrecedence
option.Is there anything you'd like reviewers to focus on?
N/A