Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: no-mixed-operators - fixes #9962 #9964

Merged
merged 1 commit into from Feb 10, 2018

Conversation

munkychop
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Improved documentation for no-mixed-operators rule - allowSamePrecedence option.

Is there anything you'd like reviewers to focus on?
N/A

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 9, 2018
@platinumazure platinumazure added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Feb 9, 2018
@platinumazure
Copy link
Member

Thanks @munkychop!

Would you mind tweaking your commit message so that it ends with "(fixes #9962)"? (Unfortunately, our commit-message status check is not yet smart enough to detect when an issue is referenced but it doesn't quite meet our preferred format.)

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'm leaving a "request changes" to avoid accidental merging before the commit message is fixed (since our commit-message status check is giving a false positive here). Thanks!

@munkychop
Copy link
Contributor Author

Sure thing, I'll update that now

@munkychop munkychop changed the title Docs: no-mixed-operators - resolves #9962 Docs: no-mixed-operators - fixes #9962 Feb 9, 2018
@platinumazure
Copy link
Member

Thanks @munkychop!

I'm sorry for being so specific but we like parentheses around the issue reference. So maybe something like "Docs: Clarify no-mixed-operators options (fixes #9962)"?

Really appreciate you sticking with this and working with us. Thanks!

@munkychop
Copy link
Contributor Author

Ah, I see. Sure thing.

@platinumazure
Copy link
Member

Thanks @munkychop, this looks great! I'm going to just let this sit for a few hours in case any other team members want to look, but we'll probably merge this pretty soon.

Thanks for contributing and fixing our docs, we really appreciate it.

@not-an-aardvark not-an-aardvark merged commit 74fa253 into eslint:master Feb 10, 2018
@not-an-aardvark
Copy link
Member

Thanks for contributing!

This was referenced Mar 19, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 10, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants