Non reporting errors for redundant space between "typeof" and "(" - related to "space-unary-ops" rule.

[chiptoe]

Tell us about your environment

• ESLint Version: v4.16.0
• Node Version: v6.10.2
• npm Version: v5.6.0

What parser (default, Babel-ESLint, etc.) are you using?
Default

Please show your full configuration:

Configuration

{
    "extends": "airbnb-base",
    "rules": {
        "prefer-arrow-callback": "off",
        "func-names": ["error", "never"],
        "space-before-function-paren": ["error", "never"],
        "indent": ["error", 4],
        "no-var": "off",
        "object-shorthand": ["error", "never"],
        "prefer-destructuring": "off",
        "import/no-unresolved": [2, {"commonjs": true}],
        "import/no-dynamic-require": "warn",
        "global-require": "warn",
        "vars-on-top": "off",
        "no-param-reassign": "off",
        "eqeqeq": "off",
        "no-use-before-define": ["error", {"functions": false}],
        "prefer-template": "off",
        "no-shadow": "off",
        "max-len": "off",
        "comma-dangle": ["error", "never"],
        "no-restricted-syntax": ["error", "BinaryExpression[operator='in']"],
        "no-continue": "off",
        "no-plusplus": "off",
        "brace-style": ["error", "stroustrup", {"allowSingleLine": false}],
        "space-unary-ops": [2, {
            "overrides": {
                "typeof": false
            }
        }]
    }
}

Last config is critical

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

var obj = null;
if (typeof (obj) === 'object') {
    console.log("THIS SHOULD REPORT ERROR BETWEEN 'typeof' AND '('. BUT IT DOESN'T");
}
if (typeof(obj) === 'object') {
    console.log('THIS IS OK AS IT DOES NOT REPORT ERROR.');
}

./node_modules/.bin/eslint issue.js

What did you expect to happen?
First case with typeof (obj) === 'object' should report error.

What actually happened? Please include the actual, raw output from ESLint.
No error was reported in first case. Actually there is nothing to show from console.

[chiptoe]

Closing in respect to #9906.

[platinumazure]

Reopening so I can tie this to my pull request.

[bladedancer]

This fix breaks: yield [1, 2, 3]
Is that the expected behaviour?

Hmm ignore that - I see from 9906 it is the "expected" behaviour.

[platinumazure]

Could you supply your config? `yield[1,2,3]` is valid JavaScript and so `yield [1,2,3]` should be flagged if using "words: false" setting. The rule was already working for object expressions (`yield {foo: 1}`). So we fixed the rule so it would apply for all non-word tokens after `yield`, basically.

…

On Feb 5, 2018 5:52 AM, "Gavin" ***@***.***> wrote: This fix breaks: yield [1, 2, 3] Is that the expected behaviour? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#9907 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWeiwZFg5oN5oy384FUW_DOVb5bqiQks5tRutpgaJpZM4Rvvi_> .