Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes #9907) #9906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
approved these changes
Jan 29, 2018
gyandeeps
approved these changes
Jan 29, 2018
platinumazure
changed the title
platinumazure
force-pushed
the
space-unary-ops-fix
branch
from
1ea47cc
to
8fd2841
Compare
platinumazure
changed the title
|
@gyandeeps @not-an-aardvark Ended up throwing in some doc changes to avoid doing another force-push (as part of fixing the PR merge message). Hopefully nothing controversial but feel free to review again if you like. Thanks! |
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
Default
Please show your full configuration:
(See demo link below)
What did you do? Please include the actual source code causing the issue.
See demo.
What did you expect to happen?
Every UnaryExpression, NewExpression, YieldExpression, and AwaitExpression should be flagged as invalid. It is possible to remove the spaces between the unary word operator and the next token.
What actually happened? Please include the actual, raw output from ESLint.
No linting errors.
What changes did you make? (Give an overview)
Changed special-case ObjectExpression check (which seemed to be used as a check for whether the next token was
{) to instead useastUtils.canTokensBeAdjacent, which generalizes the logic and allows the rule to work correctly with(and[tokens.Is there anything you'd like reviewers to focus on?
Not really.