Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add prefer-destructuring variable reassignment example #9873

Merged
merged 3 commits into from Feb 2, 2018
Merged

Docs: Add prefer-destructuring variable reassignment example #9873

merged 3 commits into from Feb 2, 2018

Conversation

lepirlouit
Copy link
Contributor

@lepirlouit lepirlouit commented Jan 22, 2018

add example with a reassignment.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: add code example.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

add example with a reassignment.
@jsf-clabot
Copy link

jsf-clabot commented Jan 22, 2018

CLA assistant check
All committers have signed the CLA.

@lepirlouit lepirlouit changed the title reassignement of variable Docs reassignement of variable Jan 22, 2018
@lepirlouit lepirlouit changed the title Docs reassignement of variable Docs: reassignement of variable Jan 22, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a line break before your changes, so that it's clear that it's a separate example (and that your two lines of code go together)?

If you wouldn't mind adding a line break between the two var lines as well, that would be nice, but not necessary.

adding a line break before changes
@platinumazure
Copy link
Member

Closing and reopening to restart Travis/AppVeyor builds.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry for taking so long to get back to this.

@platinumazure platinumazure changed the title Docs: reassignement of variable Docs: Add example of correct prefer-destructuring code involving variable reassignment Feb 2, 2018
@platinumazure platinumazure changed the title Docs: Add example of correct prefer-destructuring code involving variable reassignment Docs: Add correct prefer-destructuring example involving variable reassignment Feb 2, 2018
@platinumazure platinumazure changed the title Docs: Add correct prefer-destructuring example involving variable reassignment Docs: Add correct prefer-destructuring variable reassignment example Feb 2, 2018
@platinumazure platinumazure changed the title Docs: Add correct prefer-destructuring variable reassignment example Docs: Add prefer-destructuring variable reassignment example Feb 2, 2018
@platinumazure platinumazure added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Feb 2, 2018
@platinumazure platinumazure merged commit 3afaff6 into eslint:master Feb 2, 2018
This was referenced Mar 16, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 3, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants