New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Typo in error message when running npm #9866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, but I think the original version is grammatically correct and the new version is grammatically incorrect.
- The noun "package manager" needs an article or determiner before it (such as "your").
- "of choice" idiom.
Thank you for valuable comment. |
@maciej-ka Thanks for the PR! I'd be okay with "a package manager of your choice", but I also don't see a strong need for this change. It's a little awkward as is, sure, but this doesn't seem like a significant improvement either. |
f4cbf88
to
0415206
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated an error message
Is there anything you'd like reviewers to focus on?
No