Fix: Removing curly quotes in no-eq-null report message

[platinumazure]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment

• ESLint Version: master
• Node Version: doesn't matter
• npm Version: doesn't matter

What parser (default, Babel-ESLint, etc.) are you using?

Default, but doesn't matter

Please show your full configuration:

{
    "rules": {
        "no-eq-null": "error"
    }
}

What did you do? Please include the actual source code causing the issue.

if (foo == null) {
}

What did you expect to happen?

Error message: Use == when comparing to null.

What actually happened? Please include the actual, raw output from ESLint.

Got an error message, but it uses a multibyte character that does not render well in some contexts and furthermore is inconsistent with the rest of the core rules.

What changes did you make? (Give an overview)

Changed the lint message for no-eq-null to avoid using multibyte characters (curly quotes).

Is there anything you'd like reviewers to focus on?

Does this feel consistent with messages in other core rules?

[not-an-aardvark]

LGTM. I think we also use ` in some places, but I'm not sure how much we use it compared to '.

[platinumazure]

True, we could normalize among those at some point. But this curly quote business has to go, for sure.

…

On Jan 16, 2018 10:02 PM, "Teddy Katz" ***@***.***> wrote: ***@***.**** approved this pull request. LGTM. I think we also use ` in some places, but I'm not sure how much we use it compared to '. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9852 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWekI1NyYMK1LRTtPelXMm20s5HE5Vks5tLXDXgaJpZM4Rgxt3> .

[j-f1]

Once we use messageIds, we’ll be able to make a new rule (maybe in eslint-plugin-eslint-plugin?) to require all messages to match a pattern (maybe only printable ASCII + space in messages?).