Indent comment indentation: Comments can align with previous/next lines of code even if whitespace in between

[platinumazure]

Tell us about your environment

• ESLint Version: 4.13.1 (via online demo)
• Node Version: N/A
• npm Version: N/A

What parser (default, Babel-ESLint, etc.) are you using?

Default parser

Please show your full configuration:

Configuration

{
    "rules": {
        "indent": ["error", 4]
    }
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

if (foo) {

// blah
    statement();

}

What did you expect to happen?

3:1 - Expected indentation of 4 spaces but found 0. (indent)

What actually happened? Please include the actual, raw output from ESLint.

No lint error.

---

The bug (as I see it) is that the indent rule has a tolerance for comments to match the indentation of the previous line, that of the next line, or the "actual correct location". However, I think this should only apply if there actually is code on the immediately previous or next lines, rather than code that is separated by one or more lines of whitespace.

[platinumazure]

@not-an-aardvark: Is this a bug, or working as designed? Thanks!

[not-an-aardvark]

I think this is technically working as designed, but I agree with your analysis that the design could be improved here by making it more strict. I'm fine with calling it a bug.

[platinumazure]

I'll work on this later this week.

[sstern6]

@platinumazure was wondering if you were still looking into this one? Wouldnt mind taking a crack at it. If youre still looking into it though no worries.

[platinumazure]

Thanks for following up! I haven't had a chance to look into this; please take a look if you are interested.

…

On Sat, May 19, 2018, 19:54 Scott Stern ***@***.***> wrote: @platinumazure <https://github.com/platinumazure> was wondering if you were still looking into this one? Wouldnt mind taking a crack at it. If youre still looking into it though no worries. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9733 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWeqdcb4Mjl-a4FXHHkF7sOK8VCYDZks5t0L63gaJpZM4RGB2-> .

[platinumazure]

Working on this.