Update: Add NewExpression support to comma-style #9591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
enhancement
|
@eslint/eslint-team Does anyone else wants to support this change? We need one more 👍 and a champion |
|
This seems like a reasonable enhancement to me! We just need a champion now. |
|
I'll champion this. Marking as accepted. |
platinumazure
added
accepted
platinumazure
approved these changes
Jan 6, 2018
ilyavolodin
approved these changes
Jan 10, 2018
not-an-aardvark
approved these changes
Jan 20, 2018
|
Thanks for contributing! |
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
comma-style
Does this change cause the rule to produce more or fewer warnings?
more, if new option is enabled
How will the change be implemented? (New option, new default behavior, etc.)?
New
exceptions.NewExpressionoption, which defaults to true, and can be set to false for the new behaviour.Please provide some example code that this change will affect:
What does the rule currently do for this code?
No errors.
What will the rule do after it's changed?
Gives an error that
',' should be placed last.What changes did you make? (Give an overview)
I added a
NewExpressionexception in the same style as the existingcomma-styleexceptions (FunctionExpressionetc.)Is there anything you'd like reviewers to focus on?