Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit formatter should output entry even for files that have no messages #9093

Closed
Sean-Der opened this issue Aug 9, 2017 · 0 comments · Fixed by #9094
Closed

JUnit formatter should output entry even for files that have no messages #9093

Sean-Der opened this issue Aug 9, 2017 · 0 comments · Fixed by #9094
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion

Comments

@Sean-Der
Copy link
Contributor

Sean-Der commented Aug 9, 2017

Tell us about your environment

  • ESLint Version: v4.4.1
  • Node Version: v6.11.2
  • npm Version: 3.10.5

What did you expect to happen?
Currently the junit formatter doesn't output any entries if a file has no errors. This causes issues with Jenkins junit parser, it assumes that no tests exist and fails with a warning.

It would also be nice to have this because it gives output for all the files that have been checked, right now files that pass are just missing from the report.

This issue was also mentioned by #16 (comment)

What actually happened? Please include the actual, raw output from ESLint.
I would like to change the output from

<?xml version="1.0" encoding="utf-8"?>
<testsuites>
</testsuites>

to

<?xml version="1.0" encoding="utf-8"?>
<testsuites>
<testsuite package="org.eslint" time="0" tests="0" errors="0" name="/home/sean/test/index.js">
</testsuite>
<testsuite package="org.eslint" time="0" tests="0" errors="0" name="/home/sean/test/out.js">
</testsuite>
</testsuites>
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Aug 9, 2017
@Sean-Der Sean-Der changed the title JUnit formatter should output entry even for empty files JUnit formatter should output entry even for files that have no messages Aug 9, 2017
@Sean-Der Sean-Der mentioned this issue Aug 9, 2017
Merged
@not-an-aardvark not-an-aardvark added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 9, 2017
not-an-aardvark pushed a commit that referenced this issue Aug 14, 2017
@Sean-Der @not-an-aardvark
Fix: Include files with no messages in junit results (#9093) (#9094)
a4f53ba
@brettdh brettdh mentioned this issue Jan 12, 2018
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 12, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Include files with no messages in junit results (#9093)
3 participants
@Sean-Der @not-an-aardvark @eslintbot