Fix: no-multiple-empty-lines errors when no line breaks (fixes #6449) #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
By analyzing the blame information on this pull request, we identified @RRMoelker, @vitorbal and @gcochard to be potential reviewers |
|
LGTM. Leaving open to get some other eyes on it. |
|
LGTM |
3 tasks
azu
added a commit
to textlint/textlint
that referenced
this pull request
Jun 18, 2016
azu
added a commit
to textlint/textlint
that referenced
this pull request
Jun 18, 2016
azu
added a commit
to textlint/textlint
that referenced
this pull request
Jun 18, 2016
* chore(npm): update devDeps * chore(eslint): avoid error no-multiple-empty-lines eslint/eslint#6449 eslint/eslint#6451
| @@ -98,7 +98,7 @@ module.exports = { | |||
|
|
|||
| linesRangeStart.push(0); | |||
| lines.forEach(function(str, i) { | |||
| var length = i < fullLines.length ? fullLines[i].length : 0, | |||
| var length = Array.isArray(fullLines) && i < fullLines.length ? fullLines[i].length : 0, | |||
There was a problem hiding this comment.
Could an alternative fix be to add || [] on line 81 above, so that it's always an array, and you don't have to check if it is one N times?
There was a problem hiding this comment.
Updated the pull with change from @ljharb.
|
LGTM |
strawbrary
force-pushed
the
no-multiple-empty-lines-fix
branch
from
09a8809
to
1e3ee8d
Compare
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.