Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fixer for object-shorthand #6412

Closed
NickHeiner opened this issue Jun 14, 2016 · 7 comments
Closed

Add a fixer for object-shorthand #6412

NickHeiner opened this issue Jun 14, 2016 · 7 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@NickHeiner
Copy link
Contributor

I would like to add a fixer for the object-shorthand property. I'll work on a PR for this now. Please let me know if you have any objections to this so I don't waste my time! Thanks.
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jun 14, 2016
@platinumazure platinumazure added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jun 14, 2016
@platinumazure
Copy link
Member

Hi @NickHeiner, your best bet is to wait until the issue is labeled "accepted" before starting a PR.

It might not hurt to show a few examples of what the fixer output would look like.

@eslint/eslint-team Thoughts on this proposal to add auto-fix to object-shorthand rule?

@nzakas
Copy link
Member

nzakas commented Jun 14, 2016

I can't think of any reason not to. 👍

@ilyavolodin
Copy link
Member

This will probably be the most complex fixer that we have. I'm 👍 to try, just need to be careful.

@NickHeiner
Copy link
Contributor Author

Ok, I'm trying it now. Thanks!

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 14, 2016
NickHeiner added a commit to NickHeiner/eslint that referenced this issue Jun 14, 2016
@NickHeiner
New: Add fixer for object-shorthand (fixes eslint#6412)
5f12ef8
@alberto
Copy link
Member

alberto commented Jun 14, 2016

#5439 might make this more difficult.

@TheSavior
Copy link
Contributor

I've been using the codemod for object-shorthand here: https://github.com/cpojer/js-codemod/blob/master/transforms/object-shorthand.js

There might be some learnings that could be made from that code.

@mikesherov
Copy link
Contributor

👍

NickHeiner added a commit to NickHeiner/eslint that referenced this issue Jun 15, 2016
@NickHeiner
New: Add fixer for object-shorthand (fixes eslint#6412)
536c094
NickHeiner added a commit to NickHeiner/eslint that referenced this issue Jun 16, 2016
@NickHeiner
New: Add fixer for object-shorthand (fixes eslint#6412)
0b37057
NickHeiner added a commit to NickHeiner/eslint that referenced this issue Jun 16, 2016
@NickHeiner
New: Add fixer for object-shorthand (fixes eslint#6412)
88f49fe
@nzakas nzakas closed this as completed in da30cf9 Jun 17, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@nzakas @alberto @TheSavior @platinumazure @mikesherov @NickHeiner @ilyavolodin @eslintbot