Fix: object-curly-newline multiline with comments (fixes #6381)
#6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| // This allows: | ||
| // var obj = { // eslint-disable-line foo | ||
| // a: 1 | ||
| // } |
There was a problem hiding this comment.
The ESLint style guide favors the following for multiline comments:
/**
* First line of comment text here
* Second goes here, etc.
* Last line
*/With the leading slash aligned with the code block below.
There was a problem hiding this comment.
Thanks, I updated it.
I want to autofix this!
mysticatea
force-pushed
the
object-curly-newline/fix-for-comments
branch
from
86a9808
to
4a43094
Compare
|
LGTM |
|
Lgtm |
Closed
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6381.
I modified the rule to use comments also to check whether an object literal is multiline or not.