Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow semi as braceless body of statements (fixes #6386) #6391

Merged
merged 1 commit into from Jun 13, 2016

Conversation

alberto
Copy link
Member

@alberto alberto commented Jun 12, 2016

No description provided.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vitorbal, @gyandeeps and @nzakas to be potential reviewers

@platinumazure
Copy link
Member

I missed the discussion- why avoid flagging the semicolon, rather than just avoiding a bad auto-fix?

@ilyavolodin
Copy link
Member

@platinumazure Cause if IfStatement doesn't have body, semi is required. And we are currently flagging it as extra.

@platinumazure
Copy link
Member

Ah, right. For some reason I thought we were recommending the use of empty
blocks there- thanks for the clarification.
On Jun 12, 2016 9:56 AM, "Ilya Volodin" notifications@github.com wrote:

@platinumazure https://github.com/platinumazure Cause if IfStatement
doesn't have body, semi is required. And we are currently flagging it as
extra.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6391 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AARWekAF4ZZfXeQJJrhX-mlt6tVk5JkMks5qLB44gaJpZM4Izvg_
.

@mysticatea
Copy link
Member

Thank you @alberto !

I'd like to fix similar issues in this, I guess WithStatement and LabelledStatement have the same problem.

@alberto
Copy link
Member Author

alberto commented Jun 12, 2016

Makes sense. I'll add those too.

@eslintbot
Copy link

LGTM

@alberto alberto changed the title Fix: allow semi in empty body of if statements (fixes #6386) Fix: allow semi as braceless body of statements (fixes #6386) Jun 13, 2016
@mysticatea
Copy link
Member

LGTM, thank you!

@ilyavolodin ilyavolodin merged commit cfdd524 into master Jun 13, 2016
@alberto alberto deleted the issue6386 branch June 13, 2016 19:48
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants