New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add test for a syntax error (fixes #6013) #6378
Conversation
LGTM |
@mysticatea shouldn't we also bump the acorn version in espree? |
@alberto Yes, I think so. I'm not sure why it is, ESLint is pinning espree's version to old one... |
You mean locally right? When you do a clean install it will install |
I just mentioned this line (current espree is 3.1.5 but ESLint is not using it) |
Oh, sorry, I misunderstood you. But |
Yes. I will open an issue and a PR later! |
It was changed in this commit: b1fd482. I don't think it was pinned intentionally. |
Thank you! |
This syntax error came to be raised since Acorn 3.2.0. This syntax error prevents a false positive of `no-undef` rule.
c9898c3
to
fac4499
Compare
LGTM |
LGTM |
Fixes #6013.
This syntax error came to be raised since Acorn 3.2.0. This syntax error prevents a false positive of
no-undef
rule.RuleTester fails always on syntax errors, so I added this test into
tests/lib/eslint.js
.