Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add test for a syntax error (fixes #6013) #6378

Merged
merged 1 commit into from Jun 17, 2016
Merged

Conversation

mysticatea
Copy link
Member

Fixes #6013.

This syntax error came to be raised since Acorn 3.2.0. This syntax error prevents a false positive of no-undef rule.

RuleTester fails always on syntax errors, so I added this test into tests/lib/eslint.js.

@eslintbot
Copy link

LGTM

@alberto
Copy link
Member

alberto commented Jun 11, 2016

@mysticatea shouldn't we also bump the acorn version in espree?

@mysticatea
Copy link
Member Author

@alberto Yes, I think so. I'm not sure why it is, ESLint is pinning espree's version to old one...

@alberto
Copy link
Member

alberto commented Jun 12, 2016

You mean locally right? When you do a clean install it will install acorn@3.2.0. But people who have 3.1.0 already installed won't automatically get it upgraded. We have to release an updated version of espree to force everyone to upgrade, and then update our espree dependency here too for the same reason.

@mysticatea
Copy link
Member Author

mysticatea commented Jun 12, 2016

I just mentioned this line (current espree is 3.1.5 but ESLint is not using it)

@alberto
Copy link
Member

alberto commented Jun 12, 2016

Oh, sorry, I misunderstood you. But espree@3.1.5 still depends on ^3.1.0 https://github.com/eslint/espree/blob/master/package.json#L24

@mysticatea
Copy link
Member Author

Yes. I will open an issue and a PR later!
And I need to investigate whether ESLint can upgrade espree or not.

@mysticatea mysticatea added the do not merge This pull request should not be merged yet label Jun 12, 2016
@alberto
Copy link
Member

alberto commented Jun 12, 2016

It was changed in this commit: b1fd482. I don't think it was pinned intentionally.

@mysticatea
Copy link
Member Author

Thank you!

This syntax error came to be raised since Acorn 3.2.0.
This syntax error prevents a false positive of `no-undef` rule.
@eslintbot
Copy link

LGTM

@mysticatea mysticatea removed the do not merge This pull request should not be merged yet label Jun 16, 2016
@nzakas
Copy link
Member

nzakas commented Jun 17, 2016

LGTM

@nzakas nzakas merged commit cf223dd into master Jun 17, 2016
@mysticatea mysticatea deleted the core/add-test-for-6013 branch June 17, 2016 23:55
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants