Fix: improve newline-per-chained-call message (fixes #6340)
#6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| }, { | ||
| message: "Expected line break after `m1().m2\\n.m3().m4().m5().m6()`." | ||
| message: "Expected line break before `.end`." |
There was a problem hiding this comment.
Might be good to add some test cases for computed properties.
|
LGTM |
mysticatea
force-pushed
the
newline-per-chained-call/fix-for-long-message
branch
from
f9bbd76
to
a035cf0
Compare
|
Thank you for the review! I updated this.
|
| function getPropertyText(node) { | ||
| var prefix = node.computed ? "[" : "."; | ||
| var lines = sourceCode.getText(node.property).split(/\r\n|\r|\n/g); | ||
| var surfix = node.computed && lines.length === 1 ? "]" : ""; |
There was a problem hiding this comment.
Thank you, I updated it.
mysticatea
force-pushed
the
newline-per-chained-call/fix-for-long-message
branch
from
a035cf0
to
675e3c7
Compare
|
LGTM |
1 similar comment
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6340.
Expected line break before 'PropertyName'.