Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port JSCS require|disallowMultipleVarDecl rules #5910

Closed
qfox opened this issue Apr 20, 2016 · 2 comments
Closed

Port JSCS require|disallowMultipleVarDecl rules #5910

qfox opened this issue Apr 20, 2016 · 2 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules
Projects
JSCS Compatibility
Milestone
JSCS Compatibility

Comments

@qfox
Copy link

qfox commented Apr 20, 2016

requireMultipleVarDecl, disallowMultipleVarDecl → http://eslint.org/docs/rules/one-var (?)

onevar doesn't cover atm these cases:

  • {requireMultipleVarDecl: true}
  • {requireMultipleVarDecl: {allExcept:["require"]}}
  • {disallowMultipleVarDecl: {allExcept:["require"]}}
  • {disallowMultipleVarDecl: {allExcept:["undefined"]}} (if it's not the same as {var: {uninitialized: "always"}})

Current one-var options: { var | let | const | uninitialized | initialized: "always"|"never" }.
@qfox qfox added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Apr 20, 2016
@qfox qfox added this to the JSCS Compatibility milestone Apr 20, 2016
@vitorbal
Copy link
Member

would this be related to #4680?

@qfox qfox mentioned this issue Apr 26, 2016
Closed
@qfox
Copy link
Author

qfox commented Apr 26, 2016

Yeah, looks like it's a pure duplicate. ;-(

@qfox qfox closed this as completed Apr 26, 2016
@qfox qfox added the duplicate label Apr 26, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules
Projects
No open projects
JSCS Compatibility
Done
Milestone
JSCS Compatibility
Development

No branches or pull requests
2 participants
@vitorbal @qfox