Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: Switch from Karma to WebdriverIO #17009

Closed
1 task done
christian-bromann opened this issue Mar 22, 2023 · 7 comments · Fixed by #17126
Closed
1 task done

Change Request: Switch from Karma to WebdriverIO #17009

christian-bromann opened this issue Mar 22, 2023 · 7 comments · Fixed by #17126
Assignees
@aladdin-add
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint

Comments

@christian-bromann
Copy link
Contributor

ESLint version

latest

What problem do you want to solve?

It seems that Karma is not much maintained anymore as browser test framework and I wonder if the Eslint team would be interested switching to WebdriverIO. I've been working on supporting unit and component based browser tests in WebdriverIO within the recent month and would love to battle test it against mature projects like Eslint. And since we all are part of the OpenJS Foundation family I thought this project would be a good fit.

I am happy to do everything need to switch the harness. I feel like the setup would become much easier and it would be also very easy to run tests across different browser if this is desired.

What do you think is the correct solution?

Run browser tests with WebdriverIO.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

Feel free to disregard if you are happy with the current setup.
@christian-bromann christian-bromann added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint labels Mar 22, 2023
@Rec0iL99
Copy link
Member

Hi @christian-bromann, thanks for the issue.

Some relevant info for the dev team:

@github-actions
Copy link

Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Apr 21, 2023
@christian-bromann
Copy link
Contributor Author

@nzakas @mdjermanovic any comments?

@github-actions github-actions bot removed the Stale label Apr 23, 2023
@aladdin-add aladdin-add self-assigned this Apr 24, 2023
@aladdin-add
Copy link
Member

yes, I think it's good to have. Let's see what other team members think.

@mdjermanovic
Copy link
Member

Since the Karma project seems inactive, I support this proposal 👍

@christian-bromann
Copy link
Contributor Author

Thanks @mdjermanovic @aladdin-add .. I will work on an initial PR for this and will get back soon!

christian-bromann added a commit to christian-bromann/eslint that referenced this issue Apr 26, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
d3fa841 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
christian-bromann added a commit to christian-bromann/eslint that referenced this issue Apr 26, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
a1f03be 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
christian-bromann added a commit to christian-bromann/eslint that referenced this issue Apr 26, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
6901951 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
@christian-bromann christian-bromann mentioned this issue Apr 26, 2023
Merged
1 task
@christian-bromann
Copy link
Contributor Author

christian-bromann commented Apr 26, 2023 •
edited

I raised a PR in #17126, there is still a bit work required as I had two skip to test but the rest works as before. Any initial feedback would be appreciated. Also if you like further enhancements like test coverage reporting, cross browser testing etc. please let me know.

christian-bromann added a commit to christian-bromann/eslint that referenced this issue May 19, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
9ffdfbc 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
christian-bromann added a commit to christian-bromann/eslint that referenced this issue Jul 7, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
fb6b167 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
christian-bromann added a commit to christian-bromann/eslint that referenced this issue Jul 14, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
dec887c 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
christian-bromann added a commit to christian-bromann/eslint that referenced this issue Jul 17, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
0f35c76 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
christian-bromann added a commit to christian-bromann/eslint that referenced this issue Aug 14, 2023
@christian-bromann
test: replace Karma with Webdriver.IO
a883d23 
The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: eslint#17009
aladdin-add pushed a commit that referenced this issue Aug 30, 2023
@christian-bromann
test: replace Karma with Webdriver.IO (#17126)
926a286 
* test: replace Karma with Webdriver.IO

The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: #17009

* update webdriverio deps

* PR feedback

* adjust tests

* build eslint before running tests

* make test file an esm file

* revert more esm changes

* make it work

* remove return value

* custom log dir for wdio tests

* auto detect chromedriver

* bump timeout, store logs

* bump timeout again

* update wdio deps

* update wdio deps

* set log level to trace

* update wdio deps and unskip tests

* no need to have this be an async test

* update deps

* make path spec file explicit

* remove Chromedriver deps

* removed wdio command
nzakas pushed a commit that referenced this issue Sep 6, 2023
@christian-bromann @nzakas
test: replace Karma with Webdriver.IO (#17126)
5972899 
* test: replace Karma with Webdriver.IO

The current test framework for browser testing (Karma) is not maintained anymore and WebdriverIO provides a more modern stack that allows to test in different browser.

This patch replaces these test frameworks.

fixes: #17009

* update webdriverio deps

* PR feedback

* adjust tests

* build eslint before running tests

* make test file an esm file

* revert more esm changes

* make it work

* remove return value

* custom log dir for wdio tests

* auto detect chromedriver

* bump timeout, store logs

* bump timeout again

* update wdio deps

* update wdio deps

* set log level to trace

* update wdio deps and unskip tests

* no need to have this be an async test

* update deps

* make path spec file explicit

* remove Chromedriver deps

* removed wdio command
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 27, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aladdin-add aladdin-add

Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: replace Karma with Webdriver.IO christian-bromann/eslint
4 participants
@christian-bromann @aladdin-add @mdjermanovic @Rec0iL99